From: Marcelo Tosatti <mtosatti@redhat.com>
To: kvm@vger.kernel.org
Subject: [patch 4/6] kvm_init_vcpu requires global lock held
Date: Tue, 23 Mar 2010 13:37:13 -0300 [thread overview]
Message-ID: <20100323163812.607279544@redhat.com> (raw)
In-Reply-To: 20100323163709.033115262@redhat.com
[-- Attachment #1: init-vcpu-inside-lock --]
[-- Type: text/plain, Size: 635 bytes --]
Since it accesses data protected by the lock.
Index: qemu-uq/vl.c
===================================================================
--- qemu-uq.orig/vl.c
+++ qemu-uq/vl.c
@@ -2447,6 +2447,7 @@ static void *kvm_cpu_thread_fn(void *arg
{
CPUState *env = arg;
+ qemu_mutex_lock(&qemu_global_mutex);
qemu_thread_self(env->thread);
if (kvm_enabled())
kvm_init_vcpu(env);
@@ -2454,7 +2455,6 @@ static void *kvm_cpu_thread_fn(void *arg
kvm_block_io_signals(env);
/* signal CPU creation */
- qemu_mutex_lock(&qemu_global_mutex);
env->created = 1;
qemu_cond_signal(&qemu_cpu_cond);
next prev parent reply other threads:[~2010-03-23 16:42 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-23 16:37 [patch 0/6] misc uq/master updates (v2) Marcelo Tosatti
2010-03-23 16:37 ` [patch 1/6] target-i386: print EFER in cpu_dump_state Marcelo Tosatti
2010-03-23 16:37 ` [patch 2/6] kvm: handle internal error Marcelo Tosatti
2010-03-23 16:37 ` [patch 3/6] kvm: allow qemu to set EPT identity mapping address Marcelo Tosatti
2010-03-23 16:37 ` Marcelo Tosatti [this message]
2010-03-23 16:37 ` [patch 5/6] kvm: init mp_state Marcelo Tosatti
2010-03-23 16:37 ` [patch 6/6] kvm: remove explicit kvm_arch_reset_vcpu from kvm_init_vcpu Marcelo Tosatti
2010-06-23 12:29 ` Avi Kivity
2010-06-23 12:33 ` Avi Kivity
2010-06-23 13:19 ` Jan Kiszka
2010-06-23 13:26 ` Avi Kivity
2010-06-23 13:29 ` Jan Kiszka
2010-06-23 13:34 ` Avi Kivity
2010-03-24 10:00 ` [patch 0/6] misc uq/master updates (v2) Avi Kivity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100323163812.607279544@redhat.com \
--to=mtosatti@redhat.com \
--cc=kvm@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox