public inbox for kvm@vger.kernel.org
 help / color / mirror / Atom feed
From: Marcelo Tosatti <mtosatti@redhat.com>
To: Avi Kivity <avi@redhat.com>
Cc: Xiao Wang <sirouni@gmail.com>, kvm@vger.kernel.org, akong@redhat.com
Subject: KVM: x86: document KVM_REQ_PENDING_TIMER usage
Date: Tue, 23 Mar 2010 14:15:53 -0300	[thread overview]
Message-ID: <20100323171553.GA20283@amt.cnet> (raw)
In-Reply-To: <4BA6125E.80006@redhat.com>


Document that KVM_REQ_PENDING_TIMER is implicitly used during guest
entry.

Signed-off-by: Marcelo Tosatti <mtosatti@redhat.com>

diff --git a/arch/x86/kvm/timer.c b/arch/x86/kvm/timer.c
index eea4043..9805f05 100644
--- a/arch/x86/kvm/timer.c
+++ b/arch/x86/kvm/timer.c
@@ -12,7 +12,8 @@ static int __kvm_timer_fn(struct kvm_vcpu *vcpu, struct kvm_timer *ktimer)
 	/*
 	 * There is a race window between reading and incrementing, but we do
 	 * not care about potentially loosing timer events in the !reinject
-	 * case anyway.
+	 * case anyway. Note: KVM_REQ_PENDING_TIMER is implicitly checked 
+	 * in vcpu_enter_guest.
 	 */
 	if (ktimer->reinject || !atomic_read(&ktimer->pending)) {
 		atomic_inc(&ktimer->pending);

  reply	other threads:[~2010-03-23 17:16 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-03-20  3:20 [PATCH] KVM: Drop KVM_REQ_PENDING_TIMER Xiao Wang
2010-03-21 12:34 ` Avi Kivity
2010-03-23 17:15   ` Marcelo Tosatti [this message]
2010-03-24  9:23     ` KVM: x86: document KVM_REQ_PENDING_TIMER usage Avi Kivity
     [not found]     ` <cf3d7eae1003231810v57a03421y4bba07c02d690a31@mail.gmail.com>
2010-03-24 15:43       ` Marcelo Tosatti

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100323171553.GA20283@amt.cnet \
    --to=mtosatti@redhat.com \
    --cc=akong@redhat.com \
    --cc=avi@redhat.com \
    --cc=kvm@vger.kernel.org \
    --cc=sirouni@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox