public inbox for kvm@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH v2] KVM test: Enable timedrift for Linux guests
@ 2010-03-24  6:25 Jason Wang
  2010-03-24 14:46 ` Lucas Meneghel Rodrigues
  0 siblings, 1 reply; 2+ messages in thread
From: Jason Wang @ 2010-03-24  6:25 UTC (permalink / raw)
  To: lmr, kvm, autotest

We should also test timedrift for Linux guests especially for guest
with pvclock. So this patch enable the timedrift for linux guests.

Changes from v1:
- Correct the wrong name for guest load cleaning
- Use -no-kvm-pit-reinjection for linux guests and -rtc-td-hack for
windows guests.

Signed-off-by: Jason Wang <jasowang@redhat.com>
---
 client/tests/kvm/tests_base.cfg.sample |   14 ++++++++++++--
 1 files changed, 12 insertions(+), 2 deletions(-)

diff --git a/client/tests/kvm/tests_base.cfg.sample b/client/tests/kvm/tests_base.cfg.sample
index 8cc83a9..29a2430 100644
--- a/client/tests/kvm/tests_base.cfg.sample
+++ b/client/tests/kvm/tests_base.cfg.sample
@@ -147,7 +147,6 @@ variants:
         type = linux_s3
 
     - timedrift:    install setup unattended_install
-        extra_params += " -rtc-td-hack"
         variants:
             - with_load:
                 type = timedrift
@@ -330,7 +329,7 @@ variants:
 variants:
     # Linux section
     - @Linux:
-        no timedrift autoit
+        no autoit
         shutdown_command = shutdown -h now
         reboot_command = shutdown -r now
         status_test_command = echo $?
@@ -342,6 +341,16 @@ variants:
         file_transfer_port = 22
         mem_chk_cmd = dmidecode -t 17 | awk -F: '/Size/ {print $2}'
         cpu_chk_cmd = grep -c processor /proc/cpuinfo
+        timedrift:
+            extra_params += " -no-kvm-pit-reinjection"
+            time_command = date +'TIME: %a %m/%d/%Y %H:%M:%S.%N'
+            time_filter_re = "(?:TIME: \w\w\w )(.{19})(?:\.\d\d)"
+            time_format = "%m/%d/%Y %H:%M:%S"
+            guest_load_command = "dd if=/dev/urandom of=/dev/null"
+            guest_load_instances = 2
+            guest_load_stop_command = "killall -9 dd"
+            host_load_command = "bzip2 -c --best /dev/urandom > /dev/null"
+            host_load_instances = 8
 
         variants:
             - Fedora:
@@ -717,6 +726,7 @@ variants:
         stress_boot:
             alive_test_cmd = systeminfo
         timedrift:
+            extra_params += " -rtc-td-hack"
             time_command = "echo TIME: %date% %time%"
             time_filter_re = "(?<=TIME: \w\w\w ).{19}(?=\.\d\d)"
             time_format = "%m/%d/%Y %H:%M:%S"


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH v2] KVM test: Enable timedrift for Linux guests
  2010-03-24  6:25 [PATCH v2] KVM test: Enable timedrift for Linux guests Jason Wang
@ 2010-03-24 14:46 ` Lucas Meneghel Rodrigues
  0 siblings, 0 replies; 2+ messages in thread
From: Lucas Meneghel Rodrigues @ 2010-03-24 14:46 UTC (permalink / raw)
  To: Jason Wang; +Cc: kvm, autotest, Michael Goldish

On Wed, Mar 24, 2010 at 3:25 AM, Jason Wang <jasowang@redhat.com> wrote:
> We should also test timedrift for Linux guests especially for guest
> with pvclock. So this patch enable the timedrift for linux guests.
>
> Changes from v1:
> - Correct the wrong name for guest load cleaning
> - Use -no-kvm-pit-reinjection for linux guests and -rtc-td-hack for
> windows guests.

Here I have a little doubt if the test is useful only while running
under these command line options (since we indeed have timedrift
failures without them). Maybe it makes more sense to create variants
with these options, to ensure that this command line will also be
tested. Michael?

> Signed-off-by: Jason Wang <jasowang@redhat.com>
> ---
>  client/tests/kvm/tests_base.cfg.sample |   14 ++++++++++++--
>  1 files changed, 12 insertions(+), 2 deletions(-)
>
> diff --git a/client/tests/kvm/tests_base.cfg.sample b/client/tests/kvm/tests_base.cfg.sample
> index 8cc83a9..29a2430 100644
> --- a/client/tests/kvm/tests_base.cfg.sample
> +++ b/client/tests/kvm/tests_base.cfg.sample
> @@ -147,7 +147,6 @@ variants:
>         type = linux_s3
>
>     - timedrift:    install setup unattended_install
> -        extra_params += " -rtc-td-hack"
>         variants:
>             - with_load:
>                 type = timedrift
> @@ -330,7 +329,7 @@ variants:
>  variants:
>     # Linux section
>     - @Linux:
> -        no timedrift autoit
> +        no autoit
>         shutdown_command = shutdown -h now
>         reboot_command = shutdown -r now
>         status_test_command = echo $?
> @@ -342,6 +341,16 @@ variants:
>         file_transfer_port = 22
>         mem_chk_cmd = dmidecode -t 17 | awk -F: '/Size/ {print $2}'
>         cpu_chk_cmd = grep -c processor /proc/cpuinfo
> +        timedrift:
> +            extra_params += " -no-kvm-pit-reinjection"
> +            time_command = date +'TIME: %a %m/%d/%Y %H:%M:%S.%N'
> +            time_filter_re = "(?:TIME: \w\w\w )(.{19})(?:\.\d\d)"
> +            time_format = "%m/%d/%Y %H:%M:%S"
> +            guest_load_command = "dd if=/dev/urandom of=/dev/null"
> +            guest_load_instances = 2
> +            guest_load_stop_command = "killall -9 dd"
> +            host_load_command = "bzip2 -c --best /dev/urandom > /dev/null"
> +            host_load_instances = 8
>
>         variants:
>             - Fedora:
> @@ -717,6 +726,7 @@ variants:
>         stress_boot:
>             alive_test_cmd = systeminfo
>         timedrift:
> +            extra_params += " -rtc-td-hack"
>             time_command = "echo TIME: %date% %time%"
>             time_filter_re = "(?<=TIME: \w\w\w ).{19}(?=\.\d\d)"
>             time_format = "%m/%d/%Y %H:%M:%S"
>
> --
> To unsubscribe from this list: send the line "unsubscribe kvm" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>



-- 
Lucas

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2010-03-24 15:01 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-03-24  6:25 [PATCH v2] KVM test: Enable timedrift for Linux guests Jason Wang
2010-03-24 14:46 ` Lucas Meneghel Rodrigues

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox