From: Marcelo Tosatti <mtosatti@redhat.com>
To: 王箫 <sirouni@gmail.com>
Cc: Avi Kivity <avi@redhat.com>, kvm@vger.kernel.org, akong@redhat.com
Subject: Re: KVM: x86: document KVM_REQ_PENDING_TIMER usage
Date: Wed, 24 Mar 2010 12:43:48 -0300 [thread overview]
Message-ID: <20100324154348.GA21609@amt.cnet> (raw)
In-Reply-To: <cf3d7eae1003231810v57a03421y4bba07c02d690a31@mail.gmail.com>
On Wed, Mar 24, 2010 at 09:10:54AM +0800, 王箫 wrote:
> Thanks for pointing that, but is it possible that explicitly check the
> pending timer with kvm_cpu_has_pending_timer() in vcpu_enter_guest()? There
> seems some function duplication between KVM_REQ_PENDING_TIMER and
> ktimer->pending.
Right. KVM_REQ_PENDING_TIMER is per vcpu, and its one bit, while there
might be multiple ktimers per vcpu (its a shortcut between hrtimers and
guest entry, bypassing irq injection).
Yes, there is some duplication.
prev parent reply other threads:[~2010-03-24 15:44 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-20 3:20 [PATCH] KVM: Drop KVM_REQ_PENDING_TIMER Xiao Wang
2010-03-21 12:34 ` Avi Kivity
2010-03-23 17:15 ` KVM: x86: document KVM_REQ_PENDING_TIMER usage Marcelo Tosatti
2010-03-24 9:23 ` Avi Kivity
[not found] ` <cf3d7eae1003231810v57a03421y4bba07c02d690a31@mail.gmail.com>
2010-03-24 15:43 ` Marcelo Tosatti [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100324154348.GA21609@amt.cnet \
--to=mtosatti@redhat.com \
--cc=akong@redhat.com \
--cc=avi@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=sirouni@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox