From mboxrd@z Thu Jan  1 00:00:00 1970
From: Marcelo Tosatti <mtosatti@redhat.com>
Subject: Re: KVM: x86: document KVM_REQ_PENDING_TIMER usage
Date: Wed, 24 Mar 2010 12:43:48 -0300
Message-ID: <20100324154348.GA21609@amt.cnet>
References: <1269055202-3195-1-git-send-email-sirouni@gmail.com>
 <4BA6125E.80006@redhat.com>
 <20100323171553.GA20283@amt.cnet>
 <cf3d7eae1003231810v57a03421y4bba07c02d690a31@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: QUOTED-PRINTABLE
Cc: Avi Kivity <avi@redhat.com>, kvm@vger.kernel.org, akong@redhat.com
To: =?utf-8?B?546L566r?= <sirouni@gmail.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mx1.redhat.com ([209.132.183.28]:34494 "EHLO mx1.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1756172Ab0CXPov (ORCPT <rfc822;kvm@vger.kernel.org>);
	Wed, 24 Mar 2010 11:44:51 -0400
Content-Disposition: inline
In-Reply-To: <cf3d7eae1003231810v57a03421y4bba07c02d690a31@mail.gmail.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

On Wed, Mar 24, 2010 at 09:10:54AM +0800, =E7=8E=8B=E7=AE=AB wrote:
> Thanks for pointing that, but is it possible that explicitly check th=
e
> pending timer with kvm_cpu_has_pending_timer() in vcpu_enter_guest()?=
 There
> seems some function duplication between KVM_REQ_PENDING_TIMER and
> ktimer->pending.

Right. KVM_REQ_PENDING_TIMER is per vcpu, and its one bit, while there
might be multiple ktimers per vcpu (its a shortcut between hrtimers and
guest entry, bypassing irq injection).

Yes, there is some duplication.