From mboxrd@z Thu Jan  1 00:00:00 1970
From: Luiz Capitulino <lcapitulino@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] qemu: jaso-parser: Output the content of
 invalid keyword
Date: Wed, 24 Mar 2010 17:38:02 -0300
Message-ID: <20100324173802.58186de2@redhat.com>
References: <1269433020-16055-1-git-send-email-akong@redhat.com>
	<4BAA03E3.8010505@twiddle.net>
	<20100324151205.GA13786@akong@redhat.com>
	<m3sk7pzp4h.fsf@blackfin.pond.sub.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Cc: Amos Kong <akong@redhat.com>, kvm@vger.kernel.org,
	qemu-devel@nongnu.org, aurelien@aurel32.net,
	Richard Henderson <rth@twiddle.net>
To: Markus Armbruster <armbru@redhat.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mx1.redhat.com ([209.132.183.28]:42065 "EHLO mx1.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S932295Ab0CXUiU (ORCPT <rfc822;kvm@vger.kernel.org>);
	Wed, 24 Mar 2010 16:38:20 -0400
In-Reply-To: <m3sk7pzp4h.fsf@blackfin.pond.sub.org>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

On Wed, 24 Mar 2010 17:00:14 +0100
Markus Armbruster <armbru@redhat.com> wrote:

> Amos Kong <akong@redhat.com> writes:
> 
> > When input some invialid word 'unknowcmd' through QMP port, qemu outputs this
> > error message:
> > "parse error: invalid keyword `%s'"
> > This patch makes qemu output the content of invalid keyword, like:
> > "parse error: invalid keyword `unknowcmd'"
> >
> > Signed-off-by: Amos Kong <akong@redhat.com>
> 
> Looks good to me.
> 
> Hint: it's best to put a version in the subject when you respin, like
> [PATCH v2] ...

 Yes, and maintainers may miss a patch down a thread (and it's a good
opportunity to fix the subject).