From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Michael S. Tsirkin" Subject: Re: [PATCH v3 1/1] Shared memory uio_pci driver Date: Thu, 25 Mar 2010 18:42:31 +0200 Message-ID: <20100325164231.GC16506@redhat.com> References: <1269497376-21903-1-git-send-email-cam@cs.ualberta.ca> <4BAB30EE.4020509@redhat.com> <8286e4ee1003250924q7cca5e71u8b8b7c6d8b785eb8@mail.gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: Avi Kivity , kvm@vger.kernel.org, qemu-devel@nongnu.org To: Cam Macdonell Return-path: Received: from mx1.redhat.com ([209.132.183.28]:60411 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750962Ab0CYQqI (ORCPT ); Thu, 25 Mar 2010 12:46:08 -0400 Content-Disposition: inline In-Reply-To: <8286e4ee1003250924q7cca5e71u8b8b7c6d8b785eb8@mail.gmail.com> Sender: kvm-owner@vger.kernel.org List-ID: On Thu, Mar 25, 2010 at 10:24:20AM -0600, Cam Macdonell wrote: > On Thu, Mar 25, 2010 at 3:46 AM, Avi Kivity wrote: > > On 03/25/2010 08:09 AM, Cam Macdonell wrote: > >> > >> This patch adds a driver for my shared memory PCI device using the= uio_pci > >> interface. =A0The driver has three memory regions. =A0The first me= mory region > >> is for > >> device registers for sending interrupts. The second BAR is for rec= eiving > >> MSI-X > >> interrupts and the third memory region maps the shared memory. =A0= The device > >> only > >> exports the first and third memory regions to userspace. > >> > >> This driver supports MSI-X and regular pin interrupts. =A0Currentl= y, the > >> number of > >> MSI vectors is set to 4 which could be increased, but the driver w= ill work > >> with > >> fewer vectors. =A0If MSI is not available, then regular interrupts= will be > >> used. > >> > > > > There is now a generic PCI 2.3 driver that can handle all PCI devic= es. =A0It > > doesn't support MSI, but if we add MSI support then it can be used = without > > the need for a specialized driver. >=20 > Agreed, I'd be happy to use the generic driver if MSI is there. What > would MSI support for UIO look like? An array of "struct uio_irq" fo= r > the different vectors? >=20 > Cam My idea was to supply a way to bind eventfd to a vector. > > > > -- > > error compiling committee.c: too many arguments to function > > > >