From mboxrd@z Thu Jan  1 00:00:00 1970
From: Eduard - Gabriel Munteanu <eduard.munteanu@linux360.ro>
Subject: Re: [Qemu-devel] [RFC PATCH 4/7] sparc: rename hw/iommu.c
Date: Tue, 30 Mar 2010 23:15:04 +0300
Message-ID: <20100330201504.GA7956@localhost>
References: <cover.1269936879.git.eduard.munteanu@linux360.ro>
 <d9001abc473c4c13180637d00643cbafc587e13a.1269936879.git.eduard.munteanu@linux360.ro>
 <f43fc5581003301006o450c6de9rbb591f1b15729d36@mail.gmail.com>
 <20100330192855.GA24846@8bytes.org>
 <i2gf43fc5581003301300m7019f68em53341d00af6d2dca@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: Joerg Roedel <joro@8bytes.org>, aliguori@us.ibm.com,
	avi@redhat.com, kvm@vger.kernel.org, qemu-devel@nongnu.org
To: Blue Swirl <blauwirbel@gmail.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mail-bw0-f209.google.com ([209.85.218.209]:35804 "EHLO
	mail-bw0-f209.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751643Ab0C3UPJ (ORCPT <rfc822;kvm@vger.kernel.org>);
	Tue, 30 Mar 2010 16:15:09 -0400
Received: by bwz1 with SMTP id 1so4696793bwz.21
        for <kvm@vger.kernel.org>; Tue, 30 Mar 2010 13:15:07 -0700 (PDT)
Content-Disposition: inline
In-Reply-To: <i2gf43fc5581003301300m7019f68em53341d00af6d2dca@mail.gmail.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

On Tue, Mar 30, 2010 at 11:00:10PM +0300, Blue Swirl wrote:
> On 3/30/10, Joerg Roedel <joro@8bytes.org> wrote:
> > On Tue, Mar 30, 2010 at 08:06:36PM +0300, Blue Swirl wrote:
> >  > On 3/30/10, Eduard - Gabriel Munteanu <eduard.munteanu@linux360.ro> wrote:
> >  > > hw/iommu.c concerns the SPARC IOMMU. However we intend to implement the
> >  > >  AMD IOMMU, which could lead to confusion unless we rename the former.
> >  >
> >  > I was also thinking of renaming the file some time ago. The correct
> >  > name would be "sun4m_iommu.c". Sun4c (while still Sparc based) had a
> >  > different architecture (IIRC CPU MMU doubled as IOMMU) and Sun4d had
> >  > several IO-UNITs instead. All Sun4m machines had an IOMMU.
> >  >
> >  > But the qdev name of the device is still "iommu" and we can't change
> >  > that. So I'm not so sure it's worth renaming. Can't AMD IOMMU reside
> >  > in amd_iommu.c?
> >
> >
> > Keeping the plain name 'iommu' will likely cause confusion when more
> >  iommu implementations are added. It is better to rename it so that the
> >  name better describes what the file implements. So this change makes
> >  sense for me.
> 
> I see. I'm OK then with "sun4m_iommu.c".

Yes, I think it's enough to just change the filename, since multiple
such devices aren't likely to conflict, in any configuration.

Then "sun4m_iommu.c" it is. Will resubmit with the next patchset.


	Eduard