public inbox for kvm@vger.kernel.org
 help / color / mirror / Atom feed
From: "Michael S. Tsirkin" <mst@redhat.com>
To: Sridhar Samudrala <sri@us.ibm.com>
Cc: Avi Kivity <avi@redhat.com>, "kvm@vger.kernel.org" <kvm@vger.kernel.org>
Subject: Re: [PATCH] kvm: Increase NR_IOBUS_DEVS limit to 200
Date: Wed, 31 Mar 2010 12:51:16 +0300	[thread overview]
Message-ID: <20100331095116.GF31085@redhat.com> (raw)
In-Reply-To: <1269992905.29847.35.camel@w-sridhar.beaverton.ibm.com>

On Tue, Mar 30, 2010 at 04:48:25PM -0700, Sridhar Samudrala wrote:
> This patch increases the current hardcoded limit of NR_IOBUS_DEVS
> from 6 to 200. We are hitting this limit when creating a guest with more
> than 1 virtio-net device using vhost-net backend. Each virtio-net
> device requires 2 such devices to service notifications from rx/tx queues.
> 
> Signed-off-by: Sridhar Samudrala <sri@us.ibm.com>
> 

I tried this, but observed a measurable performance
degradation with vhost net and this patch. Did not
investigate yet.  Do you see this as well?

> diff --git a/include/linux/kvm_host.h b/include/linux/kvm_host.h
> index a3fd0f9..7fb48d3 100644
> --- a/include/linux/kvm_host.h
> +++ b/include/linux/kvm_host.h
> @@ -54,7 +54,7 @@ extern struct kmem_cache *kvm_vcpu_cache;
>   */
>  struct kvm_io_bus {
>  	int                   dev_count;
> -#define NR_IOBUS_DEVS 6
> +#define NR_IOBUS_DEVS 200 
>  	struct kvm_io_device *devs[NR_IOBUS_DEVS];
>  };
>  
> 
> 

  reply	other threads:[~2010-03-31  9:54 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-03-30 23:48 [PATCH] kvm: Increase NR_IOBUS_DEVS limit to 200 Sridhar Samudrala
2010-03-31  9:51 ` Michael S. Tsirkin [this message]
2010-03-31 20:04   ` Sridhar Samudrala
2010-04-01  8:52 ` Avi Kivity

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100331095116.GF31085@redhat.com \
    --to=mst@redhat.com \
    --cc=avi@redhat.com \
    --cc=kvm@vger.kernel.org \
    --cc=sri@us.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox