Re: [PATCH] KVM: move DR register access handling into generic code.

Jan Kiszka
2010-04-12T16:10:07Z

Avi Kivity wrote:
> On 04/12/2010 03:27 PM, Gleb Natapov wrote:
>> Currently both SVM and VMX have their own DR handling code. Move it to
>> x86.c.
>>
>>
>
> The standard process is to make them identical first and finally merge
> identical code, but I guess we can skip it in this case (Jan?)

Looks OK, I would just...

> +int kvm_set_dr(struct kvm_vcpu *vcpu, int dr, unsigned long val)
> +{
> + switch (dr) {
> + case 0 ... 3:
> + vcpu->arch.db[dr] = val;
> + if (!(vcpu->guest_debug & KVM_GUESTDBG_USE_HW_BP))
> + vcpu->arch.eff_db[dr] = val;
> + break;
> + case 4:
> + if (kvm_read_cr4_bits(vcpu, X86_CR4_DE)) {
> + kvm_queue_exception(vcpu, UD_VECTOR);
> + return 1;
> + }
> + /* fall through */
> + case 6:
> + if (val & 0xffffffff00000000ULL) {
> + kvm_inject_gp(vcpu, 0);
> + return -1;

...either return 1 or -1 on failure.

Jan

--
Siemens AG, Corporate Technology, CT T DE IT 1
Corporate Competence Center Embedded Linux