From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marcelo Tosatti Subject: Re: [PATCH] KVM: MMU: Replace role.glevels with role.cr4_pae Date: Thu, 15 Apr 2010 13:58:56 -0300 Message-ID: <20100415165856.GC16818@amt.cnet> References: <1271262003-29973-1-git-send-email-avi@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: kvm@vger.kernel.org To: Avi Kivity Return-path: Received: from mx1.redhat.com ([209.132.183.28]:37974 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755733Ab0DORXo (ORCPT ); Thu, 15 Apr 2010 13:23:44 -0400 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o3FHNhCm010591 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Thu, 15 Apr 2010 13:23:43 -0400 Content-Disposition: inline In-Reply-To: <1271262003-29973-1-git-send-email-avi@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On Wed, Apr 14, 2010 at 07:20:03PM +0300, Avi Kivity wrote: > There is no real distinction between glevels=3 and glevels=4; both have > exactly the same format and the code is treated exactly the same way. Drop > role.glevels and replace is with role.cr4_pae (which is meaningful). This > simplifies the code a bit. > > As a side effect, it allows sharing shadow page tables between pae and > longmode guest page tables at the same guest page. > > Signed-off-by: Avi Kivity Applied, thanks.