From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ingo Molnar <mingo@elte.hu>
Subject: Re: [PATCH V4 1/2] perf & kvm: Enhance perf to collect KVM guest os
 statistics from host side
Date: Sat, 17 Apr 2010 21:13:08 +0200
Message-ID: <20100417191308.GA25160@elte.hu>
References: <1271403275.2078.509.camel@ymzhang.sh.intel.com>
 <4BC9FC9A.6050807@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: "Zhang, Yanmin" <yanmin_zhang@linux.intel.com>,
	Peter Zijlstra <a.p.zijlstra@chello.nl>,
	Sheng Yang <sheng@linux.intel.com>,
	Marcelo Tosatti <mtosatti@redhat.com>,
	oerg Roedel <joro@8bytes.org>, kvm@vger.kernel.org,
	Jes Sorensen <Jes.Sorensen@redhat.com>,
	linux-kernel@vger.kernel.org, Zachary Amsden <zamsden@redhat.com>,
	Gleb Natapov <gleb@redhat.com>, tim.c.chen@intel.com,
	zhiteng.huang@intel.com,
	Arnaldo Carvalho de Melo <acme@infradead.org>
To: Avi Kivity <avi@redhat.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mx3.mail.elte.hu ([157.181.1.138]:60962 "EHLO mx3.mail.elte.hu"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1754287Ab0DQTNV (ORCPT <rfc822;kvm@vger.kernel.org>);
	Sat, 17 Apr 2010 15:13:21 -0400
Content-Disposition: inline
In-Reply-To: <4BC9FC9A.6050807@redhat.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>


* Avi Kivity <avi@redhat.com> wrote:

> On 04/16/2010 10:34 AM, Zhang, Yanmin wrote:
> >Below is the kernel patch to enable perf to collect guest os statistics.
> >
> >Joerg,
> >
> >Would you like to add support on svm? I don't know the exact point to trigger
> >NMI to host with svm.
> >
> >See below code with vmx:
> >
> >+		kvm_before_handle_nmi(&vmx->vcpu);
> >  		asm("int $2");
> >+		kvm_after_handle_nmi(&vmx->vcpu);
> >
> >Signed-off-by: Zhang Yanmin<yanmin_zhang@linux.intel.com>
> 
> Can you please split it further?
> 
> Patch 1 introduces perf_register_guest_info_callbacks() and related. Ingo 
> can merge this into a branch in tip.git. Patch 2 is just the kvm bits, I'll 
> apply that after merging the branch with patch 1. Patch 3 adds the 
> tools/perf changes.
> 
> This way perf development can continue on tip.git, and kvm development can 
> continue on kvm.git, without the code bases diverging and requiring a merge 
> later.

I'd like to pull the KVM bits from you into perf - so that there's a testable 
form of the changes. We can do that via a branch that has 1-2 changes, plus 
minimal conflicts down the line, right?

	Ingo