From: "Øyvind Sæther" <oyvinds@everdot.org>
To: Avi Kivity <avi@redhat.com>
Subject: Re: [PATCH] VGA Bios allow 1920x1080
Date: Sat, 17 Apr 2010 23:06:52 +0200 [thread overview]
Message-ID: <201004172306.52322.oyvinds@everdot.org> (raw)
In-Reply-To: <4BCA1A0A.4040703@redhat.com>
[-- Attachment #1: Type: Text/Plain, Size: 2297 bytes --]
> > The patch lets me run 1920x1080 resolution, some displays are only that
> > and not 1920x1200 these days. Gentoos ebuild doesn't seem to make the
> > vgabios and only uses /pc-bios/vgabios.bin, making kvm/vgabios and
> > replace vgabios.bin with the VGABIOS-lgpl-latest.bin it makes works (for
> > me).
> Missing signoff.
I have never submitted much to any big project, so sorry, and am not sure what
you mean by "Missing signoff". How do I .. signoff?
> > --- vbetables-gen.c 2010-04-13 06:04:09.874359455 +0200
> > +++ vbetables-gen.c.new 2010-04-13 06:04:03.955480621 +0200
> > @@ -73,12 +73,15 @@
> >
> > { 1680, 1050, 16 , 0x184},
> > { 1680, 1050, 24 , 0x185},
> > { 1680, 1050, 32 , 0x186},
> >
> > -{ 1920, 1200, 16 , 0x187},
> > -{ 1920, 1200, 24 , 0x188},
> > -{ 1920, 1200, 32 , 0x189},
> > -{ 2560, 1600, 16 , 0x18a},
> > -{ 2560, 1600, 24 , 0x18b},
> > -{ 2560, 1600, 32 , 0x18c},
> > +{ 1920, 1080, 16 , 0x187},
> > +{ 1920, 1080, 24 , 0x188},
> > +{ 1920, 1080, 32 , 0x189},
> > +{ 1920, 1200, 16 , 0x18a},
> > +{ 1920, 1200, 24 , 0x18b},
> > +{ 1920, 1200, 32 , 0x18c},
> > +{ 2560, 1600, 16 , 0x18d},
> > +{ 2560, 1600, 24 , 0x18e},
> > +{ 2560, 1600, 32 , 0x18f},
> >
> > { 0, },
> > };
>
> Please don't modify the existing mode numbers.
So sorry about that, it somehow just looked cleaner to get them listed in
sequense. Adding new modes to the end of what was there works too.
--- vbetables-gen.c.original 2010-04-13 05:51:09.134232495 +0200
+++ vbetables-gen.c.new3 2010-04-17 23:05:39.722313167 +0200
@@ -79,6 +79,9 @@
{ 2560, 1600, 16 , 0x18a},
{ 2560, 1600, 24 , 0x18b},
{ 2560, 1600, 32 , 0x18c},
+{ 1920, 1080, 16 , 0x18d},
+{ 1920, 1080, 24 , 0x18e},
+{ 1920, 1080, 32 , 0x18f},
{ 0, },
};
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 198 bytes --]
next prev parent reply other threads:[~2010-04-17 21:13 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-13 4:07 [PATCH] VGA Bios allow 1920x1080 Øyvind Sæther
2010-04-17 20:28 ` Avi Kivity
2010-04-17 21:06 ` Øyvind Sæther [this message]
2010-04-18 2:41 ` Amos Kong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201004172306.52322.oyvinds@everdot.org \
--to=oyvinds@everdot.org \
--cc=avi@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox