From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marcelo Tosatti Subject: Re: [PATCH] KVM: MMU: Drop cr4.pge from shadow page role Date: Mon, 19 Apr 2010 23:28:27 -0300 Message-ID: <20100420022827.GA28840@amt.cnet> References: <1271687509-18944-1-git-send-email-avi@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: kvm@vger.kernel.org To: Avi Kivity Return-path: Received: from mx1.redhat.com ([209.132.183.28]:26462 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751922Ab0DTChy (ORCPT ); Mon, 19 Apr 2010 22:37:54 -0400 Received: from int-mx04.intmail.prod.int.phx2.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.17]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o3K2brHY015158 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Mon, 19 Apr 2010 22:37:53 -0400 Content-Disposition: inline In-Reply-To: <1271687509-18944-1-git-send-email-avi@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On Mon, Apr 19, 2010 at 05:31:49PM +0300, Avi Kivity wrote: > Since commit bf47a760f66ad, we no longer handle ptes with the global bit > set specially, so there is no reason to distinguish between shadow pages > created with cr4.gpe set and clear. > > Such tracking is expensive when the guest toggles cr4.pge, so drop it. > > Signed-off-by: Avi Kivity ACK