Re: [PATCH] block: Free iovec arrays allocated by multiwrite_merge()

[Brian Jackson <iggy@theiggy.com>]

On Wednesday 21 April 2010 13:35:36 Ryan Harper wrote:
> * Stefan Hajnoczi <stefanha@linux.vnet.ibm.com> [2010-04-21 13:27]:
> > A new iovec array is allocated when creating a merged write request.
> > This patch ensures that the iovec array is deleted in addition to its
> > qiov owner.
> 
> Nice catch.  Send this to qemu-devel and Avi and merge into qemu-kvm
> once it's commited there.


And tag for the stable release that should be coming soon?


> 
> > Signed-off-by: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
> > ---
> >  block.c |    3 +++
> >  1 files changed, 3 insertions(+), 0 deletions(-)
> >
> > diff --git a/block.c b/block.c
> > index e891544..2d31474 100644
> > --- a/block.c
> > +++ b/block.c
> > @@ -1731,6 +1731,9 @@ static void multiwrite_user_cb(MultiwriteCB *mcb)
> >
> >      for (i = 0; i < mcb->num_callbacks; i++) {
> >          mcb->callbacks[i].cb(mcb->callbacks[i].opaque, mcb->error);
> > +        if (mcb->callbacks[i].free_qiov) {
> > +            qemu_iovec_destroy(mcb->callbacks[i].free_qiov);
> > +        }
> >          qemu_free(mcb->callbacks[i].free_qiov);
> >          qemu_vfree(mcb->callbacks[i].free_buf);
> >      }
>