From mboxrd@z Thu Jan 1 00:00:00 1970 From: Leszek Urbanski Subject: Re: [PATCH] block: Free iovec arrays allocated by multiwrite_merge() Date: Wed, 21 Apr 2010 21:59:28 +0200 Message-ID: <20100421195928.GA26113@moo.pl> References: <20100421143209.GC24351@us.ibm.com> <1271874464-3021-1-git-send-email-stefanha@linux.vnet.ibm.com> <20100421183536.GG24351@us.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-2 Cc: Stefan Hajnoczi , Michael Tokarev , Avi Kivity , Ryan Harper To: kvm@vger.kernel.org Return-path: Received: from moo.pl ([217.149.240.132]:33631 "EHLO moo.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752497Ab0DUT7d (ORCPT ); Wed, 21 Apr 2010 15:59:33 -0400 Content-Disposition: inline In-Reply-To: <20100421183536.GG24351@us.ibm.com> Sender: kvm-owner@vger.kernel.org List-ID: <20100421183536.GG24351@us.ibm.com>; from Ryan Harper on Wed, Apr 21, 2010 at 13:35:36 -0500 > * Stefan Hajnoczi [2010-04-21 13:27]: > > A new iovec array is allocated when creating a merged write request. > > This patch ensures that the iovec array is deleted in addition to its > > qiov owner. > > Nice catch. Send this to qemu-devel and Avi and merge into qemu-kvm > once it's commited there. Nice catch indeed. Debugging with mtrace() also pointed to the iovec code as the culprit. It's been running for 45 minutes with this patch applied - no leaks. Thanks! -- Leszek "Tygrys" Urbanski, SCSA, SCNA "Unix-to-Unix Copy Program;" said PDP-1. "You will never find a more wretched hive of bugs and flamers. We must be cautious." -- DECWARS http://cygnus.moo.pl/ -- Cygnus High Altitude Balloon