From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ryan Harper <ryanh@us.ibm.com>
Subject: Re: [PATCH] block: Free iovec arrays allocated by multiwrite_merge()
Date: Wed, 21 Apr 2010 15:03:58 -0500
Message-ID: <20100421200358.GH24351@us.ibm.com>
References: <20100421143209.GC24351@us.ibm.com> <1271874464-3021-1-git-send-email-stefanha@linux.vnet.ibm.com> <20100421183536.GG24351@us.ibm.com> <20100421195928.GA26113@moo.pl>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: kvm@vger.kernel.org, Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>,
	Michael Tokarev <mjt@tls.msk.ru>, Avi Kivity <avi@redhat.com>,
	Ryan Harper <ryanh@us.ibm.com>
To: Leszek Urbanski <tygrys@moo.pl>
Return-path: <kvm-owner@vger.kernel.org>
Received: from e37.co.us.ibm.com ([32.97.110.158]:44114 "EHLO
	e37.co.us.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1753990Ab0DUUEO (ORCPT <rfc822;kvm@vger.kernel.org>);
	Wed, 21 Apr 2010 16:04:14 -0400
Received: from d03relay01.boulder.ibm.com (d03relay01.boulder.ibm.com [9.17.195.226])
	by e37.co.us.ibm.com (8.14.3/8.13.1) with ESMTP id o3LK2c9D029212
	for <kvm@vger.kernel.org>; Wed, 21 Apr 2010 14:02:38 -0600
Received: from d03av03.boulder.ibm.com (d03av03.boulder.ibm.com [9.17.195.169])
	by d03relay01.boulder.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id o3LK48BN090088
	for <kvm@vger.kernel.org>; Wed, 21 Apr 2010 14:04:10 -0600
Received: from d03av03.boulder.ibm.com (loopback [127.0.0.1])
	by d03av03.boulder.ibm.com (8.14.3/8.13.1/NCO v10.0 AVout) with ESMTP id o3LD42N8002442
	for <kvm@vger.kernel.org>; Wed, 21 Apr 2010 07:04:04 -0600
Content-Disposition: inline
In-Reply-To: <20100421195928.GA26113@moo.pl>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

* Leszek Urbanski <tygrys@moo.pl> [2010-04-21 14:59]:
> <20100421183536.GG24351@us.ibm.com>; from Ryan Harper on Wed, Apr 21, 2010 at 13:35:36 -0500
> > * Stefan Hajnoczi <stefanha@linux.vnet.ibm.com> [2010-04-21 13:27]:
> > > A new iovec array is allocated when creating a merged write request.
> > > This patch ensures that the iovec array is deleted in addition to its
> > > qiov owner.
> > 
> > Nice catch.  Send this to qemu-devel and Avi and merge into qemu-kvm
> > once it's commited there.
> 
> Nice catch indeed.
> 
> Debugging with mtrace() also pointed to the iovec code as the culprit.

I've not used mtrace before, could you dump your command invocation for
the list?  I know other's would be glad to see an example with kvm

-- 
Ryan Harper
Software Engineer; Linux Technology Center
IBM Corp., Austin, Tx
ryanh@us.ibm.com