public inbox for kvm@vger.kernel.org
 help / color / mirror / Atom feed
From: Arnd Bergmann <arnd-r2nGTMty4D4@public.gmane.org>
To: Avi Kivity <avi-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
Cc: "Alexander Graf" <agraf-l3A5Bk7waGM@public.gmane.org>,
	"Fernando Luis Vázquez Cao"
	<fernando-gVGce1chcLdL9jVzuh4AOg@public.gmane.org>,
	"Takuya Yoshikawa"
	<yoshikawa.takuya-gVGce1chcLdL9jVzuh4AOg@public.gmane.org>,
	mtosatti-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org,
	kvm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	kvm-ia64-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	kvm-ppc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH RFC v2 6/6] KVM: introduce a new API for getting dirty bitmaps
Date: Fri, 23 Apr 2010 15:12:55 +0200	[thread overview]
Message-ID: <201004231512.55240.arnd@arndb.de> (raw)
In-Reply-To: <4BD19831.5000405-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>

On Friday 23 April 2010, Avi Kivity wrote:
> Ah so the 31st bit is optional as far as userspace is concerned?  What 
> does it mean? (just curious)

On data pointers it's ignored. When you branch to a function, this bit
determines whether the target function is run in 24 or 31 bit mode.
This allows linking to legacy code on older operating systems that
also support 24 bit libraries.

> What happens on the opposite conversion?  is it restored?
> 
> What about
> 
> int compare_pointer(void *a, void *b)
> {
>         unsigned long ai = (unsigned long)a;
>         void *aia = (void *)ai;
> 
>         return a == b; /* true if a and b point to the same object */
> }

Some instructions set the bit, others clear it, so aia and a may not
be bitwise identical.

> Does gcc mask the big in pointer comparisons as well?

Yes. To stay in the above example:

a == aia;					/* true */
(unsigned long)a == (unsigned long)aia;		/* true */
*(unsigned long *)&a == *(unsigned long *)&aia; /* undefined on s390 */

	Arnd

  parent reply	other threads:[~2010-04-23 13:12 UTC|newest]

Thread overview: 47+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-04-20 10:53 [PATCH RFC v2 0/6] KVM: moving dirty gitmaps to user space! Takuya Yoshikawa
2010-04-20 10:54 ` Alexander Graf
     [not found]   ` <C70797C1-08EC-4DBA-9595-4047CAE8E457-l3A5Bk7waGM@public.gmane.org>
2010-04-20 11:13     ` Takuya Yoshikawa
2010-04-20 10:56 ` [PATCH RFC v2 1/6] KVM: introduce slot level dirty state management Takuya Yoshikawa
2010-04-20 10:57 ` [PATCH RFC v2 2/6] KVM: introduce wrapper functions to create and destroy dirty bitmaps Takuya Yoshikawa
2010-04-20 11:00 ` [PATCH RFC v2 4/6] KVM: change mark_page_dirty() to handle endian issues explicitly Takuya Yoshikawa
     [not found]   ` <20100420200043.956302db.yoshikawa.takuya-gVGce1chcLdL9jVzuh4AOg@public.gmane.org>
2010-04-20 11:00     ` Alexander Graf
2010-04-20 11:20       ` Takuya Yoshikawa
2010-04-21 11:15   ` Avi Kivity
     [not found] ` <20100420195349.dab60b1d.yoshikawa.takuya-gVGce1chcLdL9jVzuh4AOg@public.gmane.org>
2010-04-20 10:59   ` [PATCH RFC v2 3/6] KVM: introduce a wrapper function to copy dirty bitmaps to user space Takuya Yoshikawa
     [not found]     ` <20100420195913.ac44281c.yoshikawa.takuya-gVGce1chcLdL9jVzuh4AOg@public.gmane.org>
2010-04-21 11:12       ` Avi Kivity
2010-04-22  8:57         ` Takuya Yoshikawa
     [not found]           ` <4BD00F64.4020405-gVGce1chcLdL9jVzuh4AOg@public.gmane.org>
2010-04-23 10:26             ` Avi Kivity
2010-04-20 11:02   ` [PATCH RFC v2 5/6] KVM: moving " Takuya Yoshikawa
     [not found]     ` <20100420200225.efca602f.yoshikawa.takuya-gVGce1chcLdL9jVzuh4AOg@public.gmane.org>
2010-04-20 11:10       ` Alexander Graf
     [not found]         ` <20234257-D6B8-44A6-BD91-C7B9D0E4970B-l3A5Bk7waGM@public.gmane.org>
2010-04-20 11:26           ` Takuya Yoshikawa
2010-04-21 11:26       ` Avi Kivity
     [not found]         ` <4BCEE0E4.6060707-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2010-04-22  9:07           ` Takuya Yoshikawa
2010-04-23 10:28             ` Avi Kivity
     [not found]               ` <4BD17665.5090101-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2010-04-23 11:14                 ` Takuya Yoshikawa
     [not found]                   ` <4BD1812E.6030707-gVGce1chcLdL9jVzuh4AOg@public.gmane.org>
2010-04-23 11:29                     ` Yoshiaki Tamura
2010-04-23 11:45                   ` Avi Kivity
2010-04-20 11:03   ` [PATCH RFC v2 6/6] KVM: introduce a new API for getting dirty bitmaps Takuya Yoshikawa
2010-04-20 11:15     ` Alexander Graf
     [not found]       ` <480E8E1E-32BD-429E-96C8-5AA69A8BDDF3-l3A5Bk7waGM@public.gmane.org>
2010-04-20 11:33         ` Takuya Yoshikawa
     [not found]           ` <4BCD90FE.9060300-gVGce1chcLdL9jVzuh4AOg@public.gmane.org>
2010-04-20 11:33             ` Alexander Graf
2010-04-20 11:44               ` Takuya Yoshikawa
2010-04-21  8:29     ` Fernando Luis Vázquez Cao
2010-04-21  9:41       ` Alexander Graf
2010-04-22  2:45         ` Fernando Luis Vázquez Cao
     [not found]           ` <4BCFB862.7010509-gVGce1chcLdL9jVzuh4AOg@public.gmane.org>
2010-04-22  6:09             ` Fernando Luis Vázquez Cao
     [not found]               ` <4BCFE805.5040500-gVGce1chcLdL9jVzuh4AOg@public.gmane.org>
2010-04-22 23:29                 ` Alexander Graf
2010-04-23 10:17                   ` Fernando Luis Vázquez Cao
2010-04-23 10:20                     ` Alexander Graf
     [not found]                       ` <9B7714E9-7244-4569-B8DB-B3E31E680CAF-l3A5Bk7waGM@public.gmane.org>
2010-04-23 11:57                         ` Avi Kivity
     [not found]                           ` <4BD18B1D.1080604-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2010-04-23 12:26                             ` Alexander Graf
2010-04-23 12:27                           ` Arnd Bergmann
2010-04-23 12:42                             ` Avi Kivity
2010-04-23 12:46                               ` Arnd Bergmann
2010-04-23 12:53                                 ` Avi Kivity
     [not found]                                   ` <4BD19831.5000405-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2010-04-23 12:59                                     ` Alexander Graf
     [not found]                                       ` <9557F344-EC7C-450F-AED9-5BB865C08650-l3A5Bk7waGM@public.gmane.org>
2010-04-23 13:20                                         ` Avi Kivity
2010-04-23 13:12                                     ` Arnd Bergmann [this message]
     [not found]     ` <20100420200353.2d2a6dec.yoshikawa.takuya-gVGce1chcLdL9jVzuh4AOg@public.gmane.org>
2010-04-21 11:46       ` Avi Kivity
     [not found]         ` <4BCEE579.9020206-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2010-04-22  9:34           ` Takuya Yoshikawa
     [not found]             ` <4BD0181C.6020900-gVGce1chcLdL9jVzuh4AOg@public.gmane.org>
2010-04-23 11:58               ` Avi Kivity
2010-04-20 12:05   ` [PATCH RFC v2 0/6] KVM: moving dirty gitmaps to user space! Takuya Yoshikawa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201004231512.55240.arnd@arndb.de \
    --to=arnd-r2ngtmty4d4@public.gmane.org \
    --cc=agraf-l3A5Bk7waGM@public.gmane.org \
    --cc=avi-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
    --cc=fernando-gVGce1chcLdL9jVzuh4AOg@public.gmane.org \
    --cc=kvm-ia64-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=kvm-ppc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=kvm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=mtosatti-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
    --cc=yoshikawa.takuya-gVGce1chcLdL9jVzuh4AOg@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox