From mboxrd@z Thu Jan  1 00:00:00 1970
From: Marcelo Tosatti <mtosatti@redhat.com>
Subject: Re: [PATCH 1/3 v2] KVM MMU: make kvm_mmu_zap_page() return the
 number of zapped sp in total.
Date: Mon, 26 Apr 2010 14:36:09 -0300
Message-ID: <20100426173609.GC21425@amt.cnet>
References: <4BD017CD.1090500@cn.fujitsu.com>
 <4BD118D7.4040102@cn.fujitsu.com>
 <4BD12A3D.8050605@cn.fujitsu.com>
 <4BD136FE.9060803@cn.fujitsu.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: Avi Kivity <avi@redhat.com>,
	Xiao Guangrong <xiaoguangrong@cn.fujitsu.com>,
	kvm@vger.kernel.org
To: Gui Jianfeng <guijianfeng@cn.fujitsu.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mx1.redhat.com ([209.132.183.28]:33302 "EHLO mx1.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1751125Ab0DZRg1 (ORCPT <rfc822;kvm@vger.kernel.org>);
	Mon, 26 Apr 2010 13:36:27 -0400
Content-Disposition: inline
In-Reply-To: <4BD136FE.9060803@cn.fujitsu.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

On Fri, Apr 23, 2010 at 01:58:22PM +0800, Gui Jianfeng wrote:
> Currently, in kvm_mmu_change_mmu_pages(kvm, page), "used_pages--" is  performed after calling
> kvm_mmu_zap_page() in spite of that whether "page" is actually reclaimed. Because root sp won't 
> be reclaimed by kvm_mmu_zap_page(). So making kvm_mmu_zap_page() return total number of reclaimed 
> sp makes more sense. A new flag is put into kvm_mmu_zap_page() to indicate whether the top page is
> reclaimed.
> 
> Signed-off-by: Gui Jianfeng <guijianfeng@cn.fujitsu.com>
> ---
>  arch/x86/kvm/mmu.c |   53 +++++++++++++++++++++++++++++++++++----------------
>  1 files changed, 36 insertions(+), 17 deletions(-)

Gui, 

There will be only a few pinned roots, and there is no need for
kvm_mmu_change_mmu_pages to be precise at that level (pages will be
reclaimed through kvm_unmap_hva eventually).