From: Marcelo Tosatti <mtosatti@redhat.com>
To: Eric Northup <digitaleric@google.com>
Cc: kvm@vger.kernel.org
Subject: Re: [PATCH RFC] KVM MMU: fix hashing for TDP and non-paging modes
Date: Mon, 26 Apr 2010 18:46:20 -0300 [thread overview]
Message-ID: <20100426214620.GA27460@amt.cnet> (raw)
In-Reply-To: <20100426213000.GK21425@amt.cnet>
On Mon, Apr 26, 2010 at 06:30:00PM -0300, Marcelo Tosatti wrote:
> > @@ -2089,6 +2089,10 @@ static int mmu_alloc_roots(struct kvm_vcpu *vcpu)
> > root_gfn = 0;
> > if (mmu_check_root(vcpu, root_gfn))
> > return 1;
> > + if (tdp_enabled) {
> > + direct = 1;
> > + root_gfn = i << 30;
> > + }
> > sp = kvm_mmu_get_page(vcpu, root_gfn, i << 30,
> > PT32_ROOT_LEVEL, direct,
> > ACC_ALL, NULL);
>
> There is no need to allocate 4 different roots for TDP tables if
> kvm_x86_ops->get_tdp_level() == PT64_ROOT_LEVEL.
Doh, and your patch does not. But it does not apply to kvm.git -next
branch, can you regenerate please?
next prev parent reply other threads:[~2010-04-26 21:48 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-22 21:15 [PATCH RFC] KVM MMU: fix hashing for TDP and non-paging modes Eric Northup
2010-04-23 11:11 ` Avi Kivity
2010-04-26 9:24 ` Avi Kivity
2010-04-26 21:30 ` Marcelo Tosatti
2010-04-26 21:46 ` Marcelo Tosatti [this message]
2010-04-27 0:00 ` Eric Northup
2010-04-27 12:31 ` Marcelo Tosatti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100426214620.GA27460@amt.cnet \
--to=mtosatti@redhat.com \
--cc=digitaleric@google.com \
--cc=kvm@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox