From mboxrd@z Thu Jan 1 00:00:00 1970 From: Gleb Natapov Subject: Re: 2.6.32.12: Build warning due to 78ce64a384 / missing in 2.6.33? Date: Tue, 27 Apr 2010 09:17:33 +0300 Message-ID: <20100427061733.GA10044@redhat.com> References: <4BD5D34E.4080503@web.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: kvm , Avi Kivity , Marcelo Tosatti To: Jan Kiszka Return-path: Received: from mx1.redhat.com ([209.132.183.28]:7173 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751202Ab0D0GRf (ORCPT ); Tue, 27 Apr 2010 02:17:35 -0400 Content-Disposition: inline In-Reply-To: <4BD5D34E.4080503@web.de> Sender: kvm-owner@vger.kernel.org List-ID: On Mon, Apr 26, 2010 at 07:54:22PM +0200, Jan Kiszka wrote: > Gleb, > > I'm getting a build warning with latest 2.6.32.12 due to "Fix segment > descriptor loading". load_segment_descriptor_to_kvm_desct is unused > after that patch. I assume it's just forgotten code and did not > accidentally become unused, right? > Yes, the function was use only in one place and was removed by upstream commit e01c2426149. > The fact that 2.6.33.3 does not generate this makes me wonder why it > obviously lacks the above patch. Not required or not yet queued? > Doesn't make much sense to include it in stable-32, but not stable-33. I think stable-32 just has more attention since it is used by many distribution as base kernel. -- Gleb.