From mboxrd@z Thu Jan 1 00:00:00 1970 From: Gleb Natapov Subject: Re: [SeaBIOS] About cpu_set, CPU hotplug and related subjects Date: Wed, 28 Apr 2010 13:30:21 +0300 Message-ID: <20100428103020.GQ10044@redhat.com> References: <1271705694.2505.36.camel@localhost.localdomain> <20100422011200.GA10677@morn.localdomain> <4BD80054.9090409@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: "Kevin O'Connor" , Lucas Meneghel Rodrigues , seabios@seabios.org, qemu mailing list , KVM mailing list To: Jes Sorensen Return-path: Received: from mx1.redhat.com ([209.132.183.28]:20564 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751986Ab0D1Ka3 (ORCPT ); Wed, 28 Apr 2010 06:30:29 -0400 Content-Disposition: inline In-Reply-To: <4BD80054.9090409@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On Wed, Apr 28, 2010 at 11:31:00AM +0200, Jes Sorensen wrote: > On 04/22/10 03:12, Kevin O'Connor wrote: > > As I understand it, the hotplug support was only in the kvm copy of > > bochs bios. It also limited the number of cpus one could use (I think > > 16). > > > > The current smp support in SeaBIOS doesn't limit the number of cpus. > > > > So, there has been reluctance to just port the old kvm bios code > > forward. > > I believe the number was limited to 15, due to limits in a certain > proprietary operating system. > > The issue with the AML code in BOCHS vs the code in Seabios is a bit > tricky. The tables in BOCHS are a fair bit more complicated with the > hotplug code and therefore statically generated, whereas Seabios > generates them dynamically at boot time. > > Generating the more complex tables dynamically would be preferred, but > it requires like half an AML compiler in Seabios, so it kinda stalled > there.... > We can try to be smart and generate most of the code statically and only minimum that absolutely required dynamically. Haven't looked at how simple dynamic part can be made. -- Gleb.