From mboxrd@z Thu Jan 1 00:00:00 1970 From: Joerg Roedel Subject: Re: [PATCH 15/22] KVM: MMU: Introduce kvm_read_guest_page_x86() Date: Wed, 28 Apr 2010 17:31:17 +0200 Message-ID: <20100428153116.GF18832@amd.com> References: <1272364712-17425-1-git-send-email-joerg.roedel@amd.com> <1272364712-17425-16-git-send-email-joerg.roedel@amd.com> <4BD6DE15.8070409@redhat.com> <20100427132030.GH11097@amd.com> <4BD6E80A.2000201@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Cc: Marcelo Tosatti , kvm@vger.kernel.org, linux-kernel@vger.kernel.org To: Avi Kivity Return-path: Received: from tx2ehsobe003.messaging.microsoft.com ([65.55.88.13]:45085 "EHLO TX2EHSOBE005.bigfish.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754040Ab0D1Pbq (ORCPT ); Wed, 28 Apr 2010 11:31:46 -0400 Content-Disposition: inline In-Reply-To: <4BD6E80A.2000201@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On Tue, Apr 27, 2010 at 04:35:06PM +0300, Avi Kivity wrote: > Perhaps have > > struct kvm_mmu base_mmu; > struct kvm_mmu nested_mmu; > struct kvm_mmu *mmu; Okay, the pointer is only used in the gva_to_gpa path which is the minority of mmu context usages. I will introduce a struct kvm_mmu *walk_mmu; and use it in the page walking code. Joerg