From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marcelo Tosatti Subject: Re: [Qemu-devel] Re: [PATCH 06/10] kvm: remove explicit kvm_arch_reset_vcpu from kvm_init_vcpu Date: Wed, 28 Apr 2010 13:22:14 -0300 Message-ID: <20100428162214.GA18168@amt.cnet> References: <1e7180606d206cc9882d4545cbf1aed29fad8088.1272304746.git.mtosatti@redhat.com> <4BD8569A.1030205@codemonkey.ws> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: qemu-devel@nongnu.org, kvm@vger.kernel.org, Avi Kivity To: Anthony Liguori Return-path: Received: from mx1.redhat.com ([209.132.183.28]:55113 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754066Ab0D1QWk (ORCPT ); Wed, 28 Apr 2010 12:22:40 -0400 Content-Disposition: inline In-Reply-To: <4BD8569A.1030205@codemonkey.ws> Sender: kvm-owner@vger.kernel.org List-ID: On Wed, Apr 28, 2010 at 10:39:06AM -0500, Anthony Liguori wrote: > On 04/26/2010 12:59 PM, Marcelo Tosatti wrote: > >This is now done via the initialization's qemu_system_reset call. > > > >Signed-off-by: Avi Kivity > >--- > > kvm-all.c | 1 - > > 1 files changed, 0 insertions(+), 1 deletions(-) > > > >diff --git a/kvm-all.c b/kvm-all.c > >index 9c8aa7d..eabb097 100644 > >--- a/kvm-all.c > >+++ b/kvm-all.c > >@@ -208,7 +208,6 @@ int kvm_init_vcpu(CPUState *env) > > ret = kvm_arch_init_vcpu(env); > > if (ret == 0) { > > qemu_register_reset(kvm_reset_vcpu, env); > >- kvm_arch_reset_vcpu(env); > > } > > err: > > return ret; > > This breaks -enable-kvm in upstream qemu. No progress is ever made > in the guest. These patches have been autotested, and just confirmed manually that this patch does not break -enable-kvm (as the reset handler is now called through the notifier). What is your qemu command line?