From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marcelo Tosatti Subject: Re: [PATCH v3 0/10] KVM MMU: allow more shadow pages become asynchronous Date: Wed, 28 Apr 2010 14:12:37 -0300 Message-ID: <20100428171237.GF18168@amt.cnet> References: <4BD7B177.9020003@cn.fujitsu.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Avi Kivity , KVM list , LKML To: Xiao Guangrong Return-path: Content-Disposition: inline In-Reply-To: <4BD7B177.9020003@cn.fujitsu.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: kvm.vger.kernel.org On Wed, Apr 28, 2010 at 11:54:31AM +0800, Xiao Guangrong wrote: > Changlog v3: > > Those changes all form Avi's suggestion, thanks. > > - use smart way to fix the bug in patch 1 > - remove duplicates code in patch 5 > - check error code and fix forgot release page in patch 9 > - sync shadow pages in a batch instead of one by one > > And, there is one TODO thing: > Marker shadow page as unsync at create time avoid write-protect, > this idea is from Avi: > > |Another interesting case is to create new shadow pages in the unsync state. > |That can help when the guest starts a short lived process: we can avoid write > |protecting its pagetables completely > > I'll send the patch out after this patchset applied. > > Changlog v2: > > - when level is PT_DIRECTORY_LEVEL, the 'offset' should be > 'role.quadrant << 8', thanks Avi for point it out > > - keep invlpg code in paging_tmpl.h address Avi's suggestion > > - split kvm_sync_page() into kvm_sync_page() and kvm_sync_page_transient() > to clarify the code address Avi's suggestion Applied, thanks.