From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marcelo Tosatti Subject: Re: [PATCHv2] qemu-kvm: fix crash on reboot with vhost-net Date: Wed, 28 Apr 2010 14:43:05 -0300 Message-ID: <20100428174304.GI18168@amt.cnet> References: <20100428092738.GA32184@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: amit.shah@redhat.com, quintela@redhat.com, kraxel@redhat.com, kvm@vger.kernel.org To: "Michael S. Tsirkin" Return-path: Received: from mx1.redhat.com ([209.132.183.28]:5274 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754850Ab0D1SFU (ORCPT ); Wed, 28 Apr 2010 14:05:20 -0400 Received: from int-mx03.intmail.prod.int.phx2.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.16]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o3SI5Kdh004462 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Wed, 28 Apr 2010 14:05:20 -0400 Content-Disposition: inline In-Reply-To: <20100428092738.GA32184@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On Wed, Apr 28, 2010 at 12:27:38PM +0300, Michael S. Tsirkin wrote: > When vhost-net is disabled on reboot, we set msix mask notifier > to NULL to disable further mask/unmask notifications. > Code currently tries to pass this NULL to notifier, > leading to a crash. The right thing to do is > to add explicit APIs to enable/disable notifications. > Now when disabling notifications: > - if vector is masked, we don't need to notify backend, > just disable future notifications > - if vector is unmasked, invoke callback to unassign backend, > then disable future notifications > > This patch also polls notifier before closing it, > to make sure we don't lose events if poll callback > didn't have time to run. > > Signed-off-by: Michael S. Tsirkin Applied, thanks.