From mboxrd@z Thu Jan  1 00:00:00 1970
From: Marcelo Tosatti <mtosatti@redhat.com>
Subject: Re: [PATCH 0/5] Fix EFER.NX=0 with EPT
Date: Wed, 28 Apr 2010 20:22:19 -0300
Message-ID: <20100428232219.GA30191@amt.cnet>
References: <1272462439-30881-1-git-send-email-avi@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: kvm@vger.kernel.org
To: Avi Kivity <avi@redhat.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mx1.redhat.com ([209.132.183.28]:51973 "EHLO mx1.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S933060Ab0D3RSw (ORCPT <rfc822;kvm@vger.kernel.org>);
	Fri, 30 Apr 2010 13:18:52 -0400
Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11])
	by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o3T9clPw010660
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)
	for <kvm@vger.kernel.org>; Thu, 29 Apr 2010 05:38:47 -0400
Content-Disposition: inline
In-Reply-To: <1272462439-30881-1-git-send-email-avi@redhat.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

On Wed, Apr 28, 2010 at 04:47:14PM +0300, Avi Kivity wrote:
> Currently we run with EFER.NX=1 on the guest even if the guest value is 0.
> This is fine with shadow, since we check bit 63 when instantiating a page
> table, and fault if bit 63 is set while EFER.NX is clear.
> 
> This doesn't work with EPT, since we no longer get the change to check guest
> ptes.  So we need to run with EFER.NX=0.
> 
> This is complicated by the fact that if we switch EFER.NX on the host, we'll
> trap immediately, since some host pages are mapped with the NX bit set.  As
> a result, we need to switch the MSR atomically during guest entry and exit.
> 
> This patchset implements the complications described above.
> 
> Avi Kivity (5):
>   KVM: Let vcpu structure alignment be determined at runtime
>   KVM: VMX: Add definition for msr autoload entry
>   KVM: VMX: Add definitions for guest and host EFER autoswitch vmcs
>     entries
>   KVM: VMX: Add facility to atomically switch MSRs on guest entry/exit
>   KVM: VMX: Atomically switch efer if EPT && !EFER.NX

Applied, thanks.

Out of curiosity, did you measure the vmentry/vmexit overhead?