From: Jason Wang <jasowang@redhat.com>
To: lmr@redhat.com, autotest@test.kernel.org
Cc: kvm@vger.kernel.org
Subject: [PATCH v2 05/10] KVM test: Log the content from guest serial console
Date: Tue, 11 May 2010 17:03:50 +0800 [thread overview]
Message-ID: <20100511090350.19914.96243.stgit@localhost.localdomain> (raw)
In-Reply-To: <20100511083338.19914.7719.stgit@localhost.localdomain>
This patch tries to get the content of guest serial and log it into
the debug directoy of the testcase through a dedicated thread which is
created in the preprocessing and ended in the postprocessing. The
params of serial_mode must be set to "dump" in order to make use of
this feature.
Signed-off-by: Jason Wang <jasowang@redhat.com>
---
client/tests/kvm/kvm_preprocessing.py | 59 +++++++++++++++++++++++++++++++-
client/tests/kvm/tests_base.cfg.sample | 1 +
2 files changed, 59 insertions(+), 1 deletions(-)
diff --git a/client/tests/kvm/kvm_preprocessing.py b/client/tests/kvm/kvm_preprocessing.py
index 4b9290c..0a33d24 100644
--- a/client/tests/kvm/kvm_preprocessing.py
+++ b/client/tests/kvm/kvm_preprocessing.py
@@ -1,4 +1,5 @@
import sys, os, time, commands, re, logging, signal, glob, threading, shutil
+import socket, select
from autotest_lib.client.bin import test, utils
from autotest_lib.client.common_lib import error
import kvm_vm, kvm_utils, kvm_subprocess, ppm_utils
@@ -13,7 +14,8 @@ except ImportError:
_screendump_thread = None
_screendump_thread_termination_event = None
-
+_serialdump_thread = None
+_serialdump_thread_termination_event = None
def preprocess_image(test, params):
"""
@@ -267,6 +269,16 @@ def preprocess(test, params, env):
args=(test, params, env))
_screendump_thread.start()
+ # Start the serial dump thread
+ if params.get("serial_mode") == "dump":
+ logging.debug("Starting serialdump thread")
+ global _serialdump_thread, _serialdump_thread_termination_event
+ _serialdump_thread_termination_event = threading.Event()
+ _serialdump_thread = threading.Thread(target=_dump_serial_console,
+ args=(test, params, env))
+ _serialdump_thread.start()
+
+
def postprocess(test, params, env):
"""
@@ -286,6 +298,13 @@ def postprocess(test, params, env):
_screendump_thread_termination_event.set()
_screendump_thread.join(10)
+ # Terminate the serialdump thread
+ global _serialdump_thread, _serialdump_thread_termination_event
+ if _serialdump_thread:
+ logging.debug("Terminating serialdump thread...")
+ _serialdump_thread_termination_event.set()
+ _serialdump_thread.join(10)
+
# Warn about corrupt PPM files
for f in glob.glob(os.path.join(test.debugdir, "*.ppm")):
if not ppm_utils.image_verify_ppm_file(f):
@@ -450,3 +469,41 @@ def _take_screendumps(test, params, env):
if _screendump_thread_termination_event.isSet():
break
_screendump_thread_termination_event.wait(delay)
+
+def _dump_serial_console(test, params, env):
+ global _serialdump_thread_termination_event
+ rs = []
+ files = {}
+
+ while True:
+ for vm in kvm_utils.env_get_all_vms(env):
+ if not vm in files and not vm.is_dead():
+ try:
+ serial_socket = socket.socket(socket.AF_UNIX,
+ socket.SOCK_STREAM)
+ serial_socket.setblocking(False)
+ serial_socket.connect(vm.serial_file_name)
+ except:
+ logging.debug("Could not connect to serial socket for %s" %
+ vm.name)
+ continue
+ rs.append(serial_socket)
+ serial_dump_filename = os.path.join(test.debugdir,
+ "serial-%s" % vm.name)
+ files[vm] = [serial_socket, file(serial_dump_filename, "a+")]
+
+ r, w, x = select.select(rs, [], [], 0.5)
+ for vm in files.keys():
+ (s ,d) = files[vm]
+ if s in r:
+ data = s.recv(16384)
+ if not data:
+ rs.remove(s)
+ files.pop(vm)
+ else:
+ d.write(data)
+
+ if _serialdump_thread_termination_event.isSet():
+ break
+
+
diff --git a/client/tests/kvm/tests_base.cfg.sample b/client/tests/kvm/tests_base.cfg.sample
index 9f82ffb..169a69e 100644
--- a/client/tests/kvm/tests_base.cfg.sample
+++ b/client/tests/kvm/tests_base.cfg.sample
@@ -13,6 +13,7 @@ start_vm = yes
kill_vm = no
kill_vm_gracefully = yes
kill_unresponsive_vms = yes
+serial_mode = dump
# Screendump specific stuff
convert_ppm_files_to_png_on_error = yes
next prev parent reply other threads:[~2010-05-11 9:03 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-11 9:03 [PATCH v2 00/10] Redirct and make use of the guest serial console Jason Wang
2010-05-11 9:03 ` [PATCH v2 01/10] KVM test: Introduce prompt assist Jason Wang
2010-05-12 22:00 ` Lucas Meneghel Rodrigues
2010-05-11 9:03 ` [PATCH v2 02/10] KVM test: Send the username in remote_login() Jason Wang
2010-05-11 9:03 ` [PATCH v2 03/10] KVM test: Make the login re suitable for serial console Jason Wang
2010-05-11 9:03 ` [PATCH v2 04/10] KVM test: Redirect the serial to the unix domain socket Jason Wang
2010-05-11 9:03 ` Jason Wang [this message]
2010-05-11 9:03 ` [PATCH v2 06/10] KVM test: Return none when met unknown type in kvm_vm.remote_login() Jason Wang
2010-05-11 9:04 ` [PATCH v2 07/10] KVM test: Introduce local_login() Jason Wang
2010-05-11 9:04 ` [PATCH v2 08/10] KVM test: Enable the serial console for all linux guests Jason Wang
2010-05-11 9:04 ` [PATCH v2 09/10] KVM test: Enable the serial console during unattended installation Jason Wang
2010-05-11 9:04 ` [PATCH v2 10/10] KVM test: Add a helper to search the panic in the log Jason Wang
2010-05-12 9:44 ` Michael Goldish
2010-05-17 7:28 ` Jason Wang
2010-05-17 21:23 ` Lucas Meneghel Rodrigues
2010-05-25 14:50 ` [PATCH v2 00/10] Redirct and make use of the guest serial console Lucas Meneghel Rodrigues
2010-05-28 8:19 ` Jason Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100511090350.19914.96243.stgit@localhost.localdomain \
--to=jasowang@redhat.com \
--cc=autotest@test.kernel.org \
--cc=kvm@vger.kernel.org \
--cc=lmr@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).