From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marcelo Tosatti Subject: Re: [qemu-kvm tests PATCH v3] qemu-kvm tests: fix linker script problem Date: Tue, 11 May 2010 11:29:35 -0300 Message-ID: <20100511142935.GC7063@amt.cnet> References: <4BE1AAAF.5000200@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: kvm@vger.kernel.org, Avi Kivity To: Naphtali Sprei Return-path: Received: from mx1.redhat.com ([209.132.183.28]:13872 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751194Ab0EKP6T (ORCPT ); Tue, 11 May 2010 11:58:19 -0400 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o4BFwJHB011655 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Tue, 11 May 2010 11:58:19 -0400 Content-Disposition: inline In-Reply-To: <4BE1AAAF.5000200@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On Wed, May 05, 2010 at 08:28:15PM +0300, Naphtali Sprei wrote: > > commit 848bd0c89c83814023cf51c72effdbc7de0d18b7 causes the linker script > itself (flat.lds) to become part of the linked objects, which messed > the output file, specifically, the symbol edata is not the last symbol > anymore. > > changes v2 -> v3 > > Instead of using a separate rule, which doesn't really adds the flat.lds to the prerequisite > list, use Avi suggestion of filtering. > > Signed-off-by: Naphtali Sprei > --- > kvm/user/config-x86-common.mak | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) Applied, thanks.