* [PATCH] Fix segfault after device assignment hot remove
@ 2010-05-06 18:58 Alex Williamson
2010-05-11 14:31 ` Marcelo Tosatti
0 siblings, 1 reply; 2+ messages in thread
From: Alex Williamson @ 2010-05-06 18:58 UTC (permalink / raw)
To: KVM list
We keep a qlist of assigned devices for irq updates, but we forgot to
remove entries from it if they're hot unplugged. This makes
assigned_dev_update_irqs() a timebomb that goes off when the guest is
rebooted.
Signed-off-by: Alex Williamson <alex.williamson@redhat.com>
---
diff --git a/hw/device-assignment.c b/hw/device-assignment.c
index 1f13a6d..b9cc06f 100644
--- a/hw/device-assignment.c
+++ b/hw/device-assignment.c
@@ -1390,6 +1390,7 @@ static int assigned_exitfn(struct PCIDevice *pci_dev)
{
AssignedDevice *dev = DO_UPCAST(AssignedDevice, dev, pci_dev);
+ QLIST_REMOVE(dev, next);
deassign_device(dev);
free_assigned_device(dev);
return 0;
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] Fix segfault after device assignment hot remove
2010-05-06 18:58 [PATCH] Fix segfault after device assignment hot remove Alex Williamson
@ 2010-05-11 14:31 ` Marcelo Tosatti
0 siblings, 0 replies; 2+ messages in thread
From: Marcelo Tosatti @ 2010-05-11 14:31 UTC (permalink / raw)
To: Alex Williamson; +Cc: KVM list
On Thu, May 06, 2010 at 12:58:12PM -0600, Alex Williamson wrote:
> We keep a qlist of assigned devices for irq updates, but we forgot to
> remove entries from it if they're hot unplugged. This makes
> assigned_dev_update_irqs() a timebomb that goes off when the guest is
> rebooted.
>
> Signed-off-by: Alex Williamson <alex.williamson@redhat.com>
> ---
Applied to master and stable-0.12, thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-05-11 15:58 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-05-06 18:58 [PATCH] Fix segfault after device assignment hot remove Alex Williamson
2010-05-11 14:31 ` Marcelo Tosatti
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).