From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marcelo Tosatti Subject: Re: [PATCH] Fix segfault after device assignment hot remove Date: Tue, 11 May 2010 11:31:51 -0300 Message-ID: <20100511143151.GD7063@amt.cnet> References: <1273172292.2616.72.camel@localhost> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: KVM list To: Alex Williamson Return-path: Received: from mx1.redhat.com ([209.132.183.28]:19158 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750912Ab0EKP6T (ORCPT ); Tue, 11 May 2010 11:58:19 -0400 Received: from int-mx04.intmail.prod.int.phx2.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.17]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o4BFwJUg011259 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Tue, 11 May 2010 11:58:19 -0400 Content-Disposition: inline In-Reply-To: <1273172292.2616.72.camel@localhost> Sender: kvm-owner@vger.kernel.org List-ID: On Thu, May 06, 2010 at 12:58:12PM -0600, Alex Williamson wrote: > We keep a qlist of assigned devices for irq updates, but we forgot to > remove entries from it if they're hot unplugged. This makes > assigned_dev_update_irqs() a timebomb that goes off when the guest is > rebooted. > > Signed-off-by: Alex Williamson > --- Applied to master and stable-0.12, thanks.