* [PATCH] fix 80000001.EDX supported bit filtering
@ 2010-05-11 6:41 Gleb Natapov
2010-05-11 20:07 ` Marcelo Tosatti
0 siblings, 1 reply; 2+ messages in thread
From: Gleb Natapov @ 2010-05-11 6:41 UTC (permalink / raw)
To: avi, mtosatti; +Cc: kvm
On AMD some bits from 1.EDX are reported in 80000001.EDX. The mask used
to copy bits from 1.EDX to 80000001.EDX is incorrect resulting in
unsupported features passed into a guest.
Signed-off-by: Gleb Natapov <gleb@redhat.com>
diff --git a/target-i386/kvm.c b/target-i386/kvm.c
index 76c1adb..6463390 100644
--- a/target-i386/kvm.c
+++ b/target-i386/kvm.c
@@ -111,7 +111,7 @@ uint32_t kvm_arch_get_supported_cpuid(CPUState *env, uint32_t function, int reg)
* so add missing bits according to the AMD spec:
*/
cpuid_1_edx = kvm_arch_get_supported_cpuid(env, 1, R_EDX);
- ret |= cpuid_1_edx & 0xdfeff7ff;
+ ret |= cpuid_1_edx & 0x183f7ff;
break;
}
break;
--
Gleb.
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] fix 80000001.EDX supported bit filtering
2010-05-11 6:41 [PATCH] fix 80000001.EDX supported bit filtering Gleb Natapov
@ 2010-05-11 20:07 ` Marcelo Tosatti
0 siblings, 0 replies; 2+ messages in thread
From: Marcelo Tosatti @ 2010-05-11 20:07 UTC (permalink / raw)
To: Gleb Natapov; +Cc: avi, kvm
On Tue, May 11, 2010 at 09:41:25AM +0300, Gleb Natapov wrote:
> On AMD some bits from 1.EDX are reported in 80000001.EDX. The mask used
> to copy bits from 1.EDX to 80000001.EDX is incorrect resulting in
> unsupported features passed into a guest.
>
> Signed-off-by: Gleb Natapov <gleb@redhat.com>
> diff --git a/target-i386/kvm.c b/target-i386/kvm.c
> index 76c1adb..6463390 100644
> --- a/target-i386/kvm.c
> +++ b/target-i386/kvm.c
> @@ -111,7 +111,7 @@ uint32_t kvm_arch_get_supported_cpuid(CPUState *env, uint32_t function, int reg)
> * so add missing bits according to the AMD spec:
> */
> cpuid_1_edx = kvm_arch_get_supported_cpuid(env, 1, R_EDX);
> - ret |= cpuid_1_edx & 0xdfeff7ff;
> + ret |= cpuid_1_edx & 0x183f7ff;
> break;
> }
> break;
Applied to uq/master, thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-05-11 20:47 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-05-11 6:41 [PATCH] fix 80000001.EDX supported bit filtering Gleb Natapov
2010-05-11 20:07 ` Marcelo Tosatti
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).