From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Wright Subject: Re: [PATCH] device-assignment: fix failure to exit on shared IRQ Date: Wed, 12 May 2010 12:54:28 -0700 Message-ID: <20100512195428.GZ28034@sequoia.sous-sol.org> References: <20100512091210.3097.57000.stgit@virtlab9.virt.bos.redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: kvm@vger.kernel.org To: Alex Williamson Return-path: Received: from sous-sol.org ([216.99.217.87]:51080 "EHLO sequoia.sous-sol.org" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1757412Ab0ELTym (ORCPT ); Wed, 12 May 2010 15:54:42 -0400 Content-Disposition: inline In-Reply-To: <20100512091210.3097.57000.stgit@virtlab9.virt.bos.redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: * Alex Williamson (alex.williamson@redhat.com) wrote: > Since c1699988, piix config space isn't programmed until the first > system reset. This means that when we call assign_irq() from > assigned_initfn(), we're going to get back an irq of 0x0, which > unfortunately matches our initialization value, so we don't bother > to call kvm_assign_irq(). Switch to a -1 initializer so we can > test whether kvm_assign_irq() is going to succeed and allow the > process to exit if it doesn't. The guest irq will get reset to a > more appropriate value on system reset anyway. > > Signed-off-by: Alex Williamson Acked-by: Chris Wright