From: Marcelo Tosatti <mtosatti@redhat.com>
To: "Xu, Dongxiao" <dongxiao.xu@intel.com>
Cc: "kvm@vger.kernel.org" <kvm@vger.kernel.org>,
Avi Kivity <avi@redhat.com>, Alexander Graf <agraf@suse.de>
Subject: Re: [PATCH 4/4 v4] KVM: VMX: VMXON/VMXOFF usage changes.
Date: Wed, 12 May 2010 16:58:26 -0300 [thread overview]
Message-ID: <20100512195826.GD3308@amt.cnet> (raw)
In-Reply-To: <D5AB6E638E5A3E4B8F4406B113A5A19A1E6E8B85@shsmsx501.ccr.corp.intel.com>
On Wed, May 12, 2010 at 02:13:26PM +0800, Xu, Dongxiao wrote:
> >> - ept_sync_global();
> >> + if (vmm_exclusive) {
> >> + kvm_cpu_vmxon(phys_addr);
> >> + ept_sync_global();
> >> + }
> >>
> >> return 0;
> >
> > The documentation recommends usage of INVEPT all-context after
> > execution of VMXON and prior to execution of VMXOFF. Is it not
> > necessary?
>
> After adding the patch, when vCPU is scheduled in a CPU, it will call
> tlb_flush() to invalidate the EPT and VPID cache/tlb for the vCPU.
> Therefore the correctness for KVM is guaranteed.
Correct. Applied all, thanks.
prev parent reply other threads:[~2010-05-12 20:05 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-11 10:29 [PATCH 4/4 v4] KVM: VMX: VMXON/VMXOFF usage changes Xu, Dongxiao
2010-05-12 0:43 ` Marcelo Tosatti
2010-05-12 6:13 ` Xu, Dongxiao
2010-05-12 19:58 ` Marcelo Tosatti [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100512195826.GD3308@amt.cnet \
--to=mtosatti@redhat.com \
--cc=agraf@suse.de \
--cc=avi@redhat.com \
--cc=dongxiao.xu@intel.com \
--cc=kvm@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).