From mboxrd@z Thu Jan  1 00:00:00 1970
From: Marcelo Tosatti <mtosatti@redhat.com>
Subject: Re: [PATCH] KVM: VMX: blocked-by-sti must not defer NMI injections
Date: Wed, 12 May 2010 17:05:11 -0300
Message-ID: <20100512200511.GE3308@amt.cnet>
References: <4BE958BE.9020503@siemens.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: Avi Kivity <avi@redhat.com>, kvm <kvm@vger.kernel.org>,
	Gleb Natapov <gleb@redhat.com>
To: Jan Kiszka <jan.kiszka@siemens.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mx1.redhat.com ([209.132.183.28]:40421 "EHLO mx1.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1751467Ab0ELUFv (ORCPT <rfc822;kvm@vger.kernel.org>);
	Wed, 12 May 2010 16:05:51 -0400
Content-Disposition: inline
In-Reply-To: <4BE958BE.9020503@siemens.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

On Tue, May 11, 2010 at 03:16:46PM +0200, Jan Kiszka wrote:
> As the processor may not consider GUEST_INTR_STATE_STI as a reason for
> blocking NMI, it could return immediately with EXIT_REASON_NMI_WINDOW
> when we asked for it. But as we consider this state as NMI-blocking, we
> can run into an endless loop.
> 
> Resolve this by allowing NMI injection if just GUEST_INTR_STATE_STI is
> active (originally suggested by Gleb). Intel confirmed that this is
> safe, the processor will never complain about NMI injection in this
> state.
> 
> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
> KVM-Stable-Tag
> ---
>  arch/x86/kvm/vmx.c |    3 +--
>  1 files changed, 1 insertions(+), 2 deletions(-)

Applied, thanks.