From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jamie Lokier <jamie@shareable.org>
Subject: Re: [Qemu-devel] Re: Another SIGFPE in display code, now in cirrus
Date: Thu, 13 May 2010 17:04:43 +0100
Message-ID: <20100513160443.GA4417@shareable.org>
References: <4BEAA0CC.4090906@redhat.com> <alpine.DEB.2.00.1005121349070.11380@kaball-desktop> <4BEABABC.6080305@redhat.com> <alpine.DEB.2.00.1005121537370.11380@kaball-desktop> <4BEAD232.2040700@redhat.com> <alpine.DEB.2.00.1005121750480.11380@kaball-desktop> <20100512170702.GE19314@shareable.org> <alpine.DEB.2.00.1005121855230.11380@kaball-desktop> <4BEBA0ED.9010009@redhat.com> <alpine.DEB.2.00.1005131329230.11380@kaball-desktop>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: Avi Kivity <avi@redhat.com>, Brian Kress <kressb@moose.net>,
	Michael Tokarev <mjt@tls.msk.ru>,
	qemu-devel <qemu-devel@nongnu.org>,
	KVM list <kvm@vger.kernel.org>
To: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mail2.shareable.org ([80.68.89.115]:41207 "EHLO
	mail2.shareable.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1759260Ab0EMQE5 (ORCPT <rfc822;kvm@vger.kernel.org>);
	Thu, 13 May 2010 12:04:57 -0400
Content-Disposition: inline
In-Reply-To: <alpine.DEB.2.00.1005131329230.11380@kaball-desktop>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

Stefano Stabellini wrote:
> > I think we need to consider only dstpitch for a full invalidate.  We 
> > might be copying an offscreen bitmap into the screen, and srcpitch is 
> > likely to be the bitmap width instead of the screen pitch.
> 
> Agreed.

Even when copying on-screen (or partially on-screen), the srcpitch
does not affect the invalidated area.  The source area might be
strange (parallelogram, single line repeated), but srcpitch should
only affect whether qemu_console_copy can be used, not the
invalidation.

-- Jamie