From: Chris Wright <chrisw@redhat.com>
To: Alex Williamson <alex.williamson@redhat.com>
Cc: kvm@vger.kernel.org, linux-kernel@vger.kernel.org, chrisw@redhat.com
Subject: Re: [PATCH] kvm: remove CAP_SYS_RAWIO requirement from kvm_vm_ioctl_assign_irq
Date: Thu, 13 May 2010 15:06:01 -0700 [thread overview]
Message-ID: <20100513220601.GH30483@x200.localdomain> (raw)
In-Reply-To: <20100512134619.30602.63792.stgit@virtlab9.virt.bos.redhat.com>
* Alex Williamson (alex.williamson@redhat.com) wrote:
> Remove this check in an effort to allow kvm guests to run without
> root privileges. This capability check doesn't seem to add any
> security since the device needs to have already been added via the
> assign device ioctl and the io actually occurs through the pci
> sysfs interface.
Right, so irq resource allocation can't be directly abused (by calling
this ioctl out of order, for example) because the device must be assigned
first via kvm_vm_ioctl_assign_device(). My only concern isn't with this
patch per-se, but the exising kvm_vm_ioctl_assign_device().
thanks,
-chris
next prev parent reply other threads:[~2010-05-13 22:06 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-12 13:46 [PATCH] kvm: remove CAP_SYS_RAWIO requirement from kvm_vm_ioctl_assign_irq Alex Williamson
2010-05-13 22:06 ` Chris Wright [this message]
2010-05-13 22:22 ` Alex Williamson
2010-05-13 22:54 ` Marcelo Tosatti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100513220601.GH30483@x200.localdomain \
--to=chrisw@redhat.com \
--cc=alex.williamson@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).