From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Wright Subject: Re: [PATCH] kvm: remove CAP_SYS_RAWIO requirement from kvm_vm_ioctl_assign_irq Date: Thu, 13 May 2010 15:06:01 -0700 Message-ID: <20100513220601.GH30483@x200.localdomain> References: <20100512134619.30602.63792.stgit@virtlab9.virt.bos.redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: kvm@vger.kernel.org, linux-kernel@vger.kernel.org, chrisw@redhat.com To: Alex Williamson Return-path: Content-Disposition: inline In-Reply-To: <20100512134619.30602.63792.stgit@virtlab9.virt.bos.redhat.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: kvm.vger.kernel.org * Alex Williamson (alex.williamson@redhat.com) wrote: > Remove this check in an effort to allow kvm guests to run without > root privileges. This capability check doesn't seem to add any > security since the device needs to have already been added via the > assign device ioctl and the io actually occurs through the pci > sysfs interface. Right, so irq resource allocation can't be directly abused (by calling this ioctl out of order, for example) because the device must be assigned first via kvm_vm_ioctl_assign_device(). My only concern isn't with this patch per-se, but the exising kvm_vm_ioctl_assign_device(). thanks, -chris