From mboxrd@z Thu Jan  1 00:00:00 1970
From: Marcelo Tosatti <mtosatti@redhat.com>
Subject: Re: [PATCH] device-assignment: fix failure to exit on shared IRQ
Date: Thu, 13 May 2010 19:41:31 -0300
Message-ID: <20100513224131.GD27620@amt.cnet>
References: <20100512091210.3097.57000.stgit@virtlab9.virt.bos.redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: kvm@vger.kernel.org
To: Alex Williamson <alex.williamson@redhat.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mx1.redhat.com ([209.132.183.28]:18320 "EHLO mx1.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1758934Ab0ENStU (ORCPT <rfc822;kvm@vger.kernel.org>);
	Fri, 14 May 2010 14:49:20 -0400
Received: from int-mx08.intmail.prod.int.phx2.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.21])
	by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o4EInJaT013788
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)
	for <kvm@vger.kernel.org>; Fri, 14 May 2010 14:49:19 -0400
Content-Disposition: inline
In-Reply-To: <20100512091210.3097.57000.stgit@virtlab9.virt.bos.redhat.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

On Wed, May 12, 2010 at 05:12:10AM -0400, Alex Williamson wrote:
> Since c1699988, piix config space isn't programmed until the first
> system reset.  This means that when we call assign_irq() from
> assigned_initfn(), we're going to get back an irq of 0x0, which
> unfortunately matches our initialization value, so we don't bother
> to call kvm_assign_irq().  Switch to a -1 initializer so we can
> test whether kvm_assign_irq() is going to succeed and allow the
> process to exit if it doesn't.  The guest irq will get reset to a
> more appropriate value on system reset anyway.
> 
> Signed-off-by: Alex Williamson <alex.williamson@redhat.com>

Applied, thanks.