From: Christoph Hellwig <hch@lst.de>
To: Stefan Hajnoczi <stefanha@gmail.com>
Cc: Avi Kivity <avi@redhat.com>, Kevin Wolf <kwolf@redhat.com>,
qemu-devel@nongnu.org, kvm@vger.kernel.org,
Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH +stable] block: don't attempt to merge overlapping requests
Date: Wed, 19 May 2010 11:31:01 +0200 [thread overview]
Message-ID: <20100519093101.GA6403@lst.de> (raw)
In-Reply-To: <AANLkTim3FdmdVUKCdk6NRJT1Ir4bGsWEibAjDh5dH-27@mail.gmail.com>
On Wed, May 19, 2010 at 10:23:44AM +0100, Stefan Hajnoczi wrote:
> On Wed, May 19, 2010 at 10:06 AM, Avi Kivity <avi@redhat.com> wrote:
> >> In the cache=writeback case the virtio-blk guest driver does:
> >>
> >> blk_queue_ordered(q, QUEUE_ORDERED_DRAIN_FLUSH, ...)
> >>
> >
> > I don't follow. ?What's the implication?
>
> I was wondering whether the queue is incorrectly set to a mode where
> overlapping write requests aren't being ordered. Anyway, Christoph
> says overlapping write requests can be issued so my theory is broken.
They can happen, but won't during usual pagecache based writeback. So
this should not happen for the pagecache based mke2fs workload. It
could happen for a workload with mkfs that uses O_DIRECT. And we
need to handle it either way.
And btw, our barrier handling for devices using multiwrite (aka virtio)
is utterly busted right now, patch will follow ASAP.
prev parent reply other threads:[~2010-05-19 9:31 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-18 17:18 [PATCH +stable] block: don't attempt to merge overlapping requests Avi Kivity
2010-05-18 19:22 ` Stefan Hajnoczi
2010-05-18 19:37 ` Stefan Hajnoczi
2010-05-18 19:41 ` Michael Tokarev
2010-05-18 20:19 ` Stefan Hajnoczi
2010-05-19 8:09 ` Avi Kivity
2010-05-19 9:01 ` Stefan Hajnoczi
2010-05-19 9:06 ` Avi Kivity
2010-05-19 9:23 ` Stefan Hajnoczi
2010-05-19 9:31 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100519093101.GA6403@lst.de \
--to=hch@lst.de \
--cc=avi@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox