From mboxrd@z Thu Jan 1 00:00:00 1970 From: Gleb Natapov Subject: Re: [PATCH] fix "info cpus" halted state display Date: Thu, 20 May 2010 13:16:17 +0300 Message-ID: <20100520101617.GE15750@redhat.com> References: <20100513131714.GC7757@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: kvm@vger.kernel.org To: avi@redhat.com, mtosatti@redhat.com Return-path: Received: from mx1.redhat.com ([209.132.183.28]:53840 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755474Ab0ETKQU (ORCPT ); Thu, 20 May 2010 06:16:20 -0400 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o4KAGJu3019650 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Thu, 20 May 2010 06:16:20 -0400 Content-Disposition: inline In-Reply-To: <20100513131714.GC7757@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On Thu, May 13, 2010 at 04:17:14PM +0300, Gleb Natapov wrote: > When in-kernel irqchip is used env->halted is never used for anything > except "info cpus" command. Halted state is synced in > kvm_arch_save_mpstate() and showed by do_info_cpus() but otherwise never > looked at. Zeroing it here breaks "info cpus" since before > do_info_cpus() outputs env->halted in io thread it is zeroed here when > vcpu thread reenters kernel. > Avi, what about this patch? > Signed-off-by: Gleb Natapov > diff --git a/qemu-kvm-x86.c b/qemu-kvm-x86.c > index 61d9331..0ec2881 100644 > --- a/qemu-kvm-x86.c > +++ b/qemu-kvm-x86.c > @@ -922,10 +922,6 @@ void kvm_arch_load_regs(CPUState *env, int level) > if (env->kvm_vcpu_update_vapic) > kvm_tpr_enable_vapic(env); > } > - if (kvm_irqchip_in_kernel()) { > - /* Avoid deadlock: no user space IRQ will ever clear it. */ > - env->halted = 0; > - } > > kvm_put_vcpu_events(env, level); > kvm_put_debugregs(env); > -- > Gleb. > -- > To unsubscribe from this list: send the line "unsubscribe kvm" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- Gleb.