From mboxrd@z Thu Jan 1 00:00:00 1970 From: Gleb Natapov Subject: Re: [PATCH] correctly trace irq injection on SVM. Date: Thu, 20 May 2010 13:20:54 +0300 Message-ID: <20100520102054.GG15750@redhat.com> References: <20100520101945.GF15750@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: kvm@vger.kernel.org To: avi@redhat.com, mtosatti@redhat.com Return-path: Received: from mx1.redhat.com ([209.132.183.28]:27037 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755489Ab0ETKU4 (ORCPT ); Thu, 20 May 2010 06:20:56 -0400 Received: from int-mx05.intmail.prod.int.phx2.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.18]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o4KAKuKD016778 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Thu, 20 May 2010 06:20:56 -0400 Content-Disposition: inline In-Reply-To: <20100520101945.GF15750@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On Thu, May 20, 2010 at 01:19:45PM +0300, Gleb Natapov wrote: > On SVM interrupts are injected by svm_set_irq() not svm_inject_irq(). > The later is used only to wait for irq window. > And of course ignore this. Haven't noticed compilation error. > Signed-off-by: Gleb Natapov > diff --git a/arch/x86/kvm/svm.c b/arch/x86/kvm/svm.c > index 58c91f5..cd70109 100644 > --- a/arch/x86/kvm/svm.c > +++ b/arch/x86/kvm/svm.c > @@ -2831,8 +2831,6 @@ static inline void svm_inject_irq(struct vcpu_svm *svm, int irq) > { > struct vmcb_control_area *control; > > - trace_kvm_inj_virq(irq); > - > ++svm->vcpu.stat.irq_injections; > control = &svm->vmcb->control; > control->int_vector = irq; > @@ -2847,6 +2845,8 @@ static void svm_set_irq(struct kvm_vcpu *vcpu) > > BUG_ON(!(gif_set(svm))); > > + trace_kvm_inj_virq(irq); > + > svm->vmcb->control.event_inj = vcpu->arch.interrupt.nr | > SVM_EVTINJ_VALID | SVM_EVTINJ_TYPE_INTR; > } > -- > Gleb. > -- > To unsubscribe from this list: send the line "unsubscribe kvm" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- Gleb.