From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Michael S. Tsirkin" Subject: Re: [PATCH][VHOST] fix race with guest on multi-buffer used buffer updates Date: Mon, 24 May 2010 20:52:03 +0300 Message-ID: <20100524175203.GB6749@redhat.com> References: <20100524164205.GA6664@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: kvm@vger.kernel.org, netdev@vger.kernel.org, netdev-owner@vger.kernel.org To: David Stevens Return-path: Received: from mx1.redhat.com ([209.132.183.28]:7888 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754533Ab0EXR4P (ORCPT ); Mon, 24 May 2010 13:56:15 -0400 Content-Disposition: inline In-Reply-To: Sender: kvm-owner@vger.kernel.org List-ID: On Mon, May 24, 2010 at 10:50:44AM -0700, David Stevens wrote: > Michael S. Tsirkin wrote on 05/24/2010 09:42:05 AM: > > > > I see. The logging is still bugg though I think. > > Possibly; migration isn't working for me under load even > without mergeable buffers (investigating), so I haven't > yet been able to test wrap w/ logging, but did you see > something specific that's wrong? > > +-DLS Yes, code only logs a single entry as dirty even if multiple entries have been written. -- MST