From mboxrd@z Thu Jan 1 00:00:00 1970 From: Joerg Roedel Subject: Re: [Qemu-devel] Re: [RFC PATCH] AMD IOMMU emulation Date: Tue, 25 May 2010 10:39:22 +0200 Message-ID: <20100525083922.GF1237@8bytes.org> References: <1274363407-24862-1-git-send-email-eduard.munteanu@linux360.ro> <20100524154030.GE1237@8bytes.org> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: Eduard - Gabriel Munteanu , aliguori@us.ibm.com, avi@redhat.com, kvm@vger.kernel.org, qemu-devel@nongnu.org To: Blue Swirl Return-path: Received: from 8bytes.org ([88.198.83.132]:57080 "EHLO 8bytes.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756217Ab0EYIjX (ORCPT ); Tue, 25 May 2010 04:39:23 -0400 Content-Disposition: inline In-Reply-To: Sender: kvm-owner@vger.kernel.org List-ID: On Mon, May 24, 2010 at 08:10:16PM +0000, Blue Swirl wrote: > On Mon, May 24, 2010 at 3:40 PM, Joerg Roedel wrote= : > >> + > >> +#define MMIO_SIZE =A0 =A0 =A0 =A0 =A0 =A0 =A0 0x2028 > > > > This size should be a power-of-two value. In this case probably 0x4= 000. >=20 > Not really, the devices can reserve regions of any size. There were > some implementation deficiencies in earlier versions of QEMU, where > the whole page would be reserved anyway, but this limitation has been > removed long time ago. The drivers for AMD IOMMU expect that to be 0x4000. At least the Linux driver maps the MMIO region with this size. So the emulation should reserve this amount of MMIO space too. Joerg