From mboxrd@z Thu Jan 1 00:00:00 1970 From: Amit Shah Subject: Re: [PATCH] vhost-net: fix reversed logic in mask notifiers Date: Tue, 25 May 2010 19:55:50 +0530 Message-ID: <20100525142550.GD6575@amit-laptop.redhat.com> References: <20100525140043.GA19688@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: kvm@vger.kernel.org, quintela@redhat.com, kraxel@redhat.com To: "Michael S. Tsirkin" Return-path: Received: from mx1.redhat.com ([209.132.183.28]:13233 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754053Ab0EYOYH (ORCPT ); Tue, 25 May 2010 10:24:07 -0400 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o4PEO6aY013736 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Tue, 25 May 2010 10:24:06 -0400 Content-Disposition: inline In-Reply-To: <20100525140043.GA19688@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On (Tue) May 25 2010 [17:00:43], Michael S. Tsirkin wrote: > When guest notifier is assigned, we set mask notifier, > which will assign kvm irqfd. > When guest notifier is unassigned, mask notifier is unset, > which should unassign kvm irqfd. > > The way to do this is to call mask notifier telling it to mask the vector. > This, unless vector is already masked which unassigns irqfd already. > > The logic in unassign was reversed, which left kvm irqfd assigned. > > This patch is qemu-kvm only as irqfd is not upstream. > > Signed-off-by: Michael S. Tsirkin > Reported-by: Amit Shah Acked-by: Amit Shah Amit