From: Alex Williamson <alex.williamson@redhat.com>
To: kvm@vger.kernel.org
Cc: quintela@redhat.com, chrisw@redhat.com, alex.williamson@redhat.com
Subject: [PATCH] device-assignment: don't truncate MSIX capabilities table size
Date: Tue, 25 May 2010 17:08:01 -0600 [thread overview]
Message-ID: <20100525230131.6313.27447.stgit@localhost.localdomain> (raw)
PCI_MSIX_TABSIZE is 0x07ff
Reported-by: Juan Quintela <quintela@redhat.com>
Signed-off-by: Alex Williamson <alex.williamson@redhat.com>
---
Applies on top of:
[PATCH qemu-kvm 1/2] device-assignment: use stdint types
[PATCH qemu-kvm 2/2] device-assignment: Don't use libpci
hw/device-assignment.c | 6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/hw/device-assignment.c b/hw/device-assignment.c
index d8e7cb4..e254203 100644
--- a/hw/device-assignment.c
+++ b/hw/device-assignment.c
@@ -1073,7 +1073,7 @@ static int assigned_dev_update_msix_mmio(PCIDevice *pci_dev)
else
pos = pci_dev->cap.start;
- entries_max_nr = pci_dev->config[pos + 2];
+ entries_max_nr = *(uint16_t *)(pci_dev->config + pos + 2);
entries_max_nr &= PCI_MSIX_TABSIZE;
entries_max_nr += 1;
@@ -1255,8 +1255,8 @@ static int assigned_device_pci_cap_init(PCIDevice *pci_dev)
entry_nr = assigned_dev_pci_read_word(pci_dev, pos + 2) &
PCI_MSIX_TABSIZE;
pci_dev->config[pci_dev->cap.start + pci_dev->cap.length] = 0x11;
- pci_dev->config[pci_dev->cap.start +
- pci_dev->cap.length + 2] = entry_nr;
+ *(uint16_t *)(pci_dev->config + pci_dev->cap.start +
+ pci_dev->cap.length + 2) = entry_nr;
msix_table_entry = assigned_dev_pci_read_long(pci_dev,
pos + PCI_MSIX_TABLE);
*(uint32_t *)(pci_dev->config + pci_dev->cap.start +
next reply other threads:[~2010-05-25 23:08 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-25 23:08 Alex Williamson [this message]
2010-05-25 23:09 ` [PATCH] device-assignment: don't truncate MSIX capabilities table size Chris Wright
2010-05-25 23:14 ` Alex Williamson
2010-05-25 23:19 ` Chris Wright
2010-05-26 0:27 ` Juan Quintela
2010-05-26 12:48 ` Avi Kivity
2010-05-26 12:54 ` Juan Quintela
2010-05-27 7:56 ` Jes Sorensen
2010-05-27 12:07 ` Avi Kivity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100525230131.6313.27447.stgit@localhost.localdomain \
--to=alex.williamson@redhat.com \
--cc=chrisw@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=quintela@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).