From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Roedel, Joerg" <Joerg.Roedel@amd.com>
Subject: Re: [PATCH] KVM: svm: Fix erratum 383 check for 32-bit hosts
Date: Wed, 26 May 2010 10:00:06 +0200
Message-ID: <20100526080006.GE23190@amd.com>
References: <4BFCC995.5000303@web.de>
 <20100526074538.GB23190@amd.com>
 <4BFCD43B.7070702@web.de>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Cc: Avi Kivity <avi@redhat.com>, Marcelo Tosatti <mtosatti@redhat.com>,
	kvm <kvm@vger.kernel.org>
To: Jan Kiszka <jan.kiszka@web.de>
Return-path: <kvm-owner@vger.kernel.org>
Received: from tx2ehsobe002.messaging.microsoft.com ([65.55.88.12]:30925 "EHLO
	TX2EHSOBE003.bigfish.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1752949Ab0EZIAQ (ORCPT <rfc822;kvm@vger.kernel.org>);
	Wed, 26 May 2010 04:00:16 -0400
Content-Disposition: inline
In-Reply-To: <4BFCD43B.7070702@web.de>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

On Wed, May 26, 2010 at 03:56:43AM -0400, Jan Kiszka wrote:
> Roedel, Joerg wrote:
> > On Wed, May 26, 2010 at 03:11:17AM -0400, Jan Kiszka wrote:
> >> From: Jan Kiszka <jan.kiszka@siemens.com>
> >>
> >> This overflow should have left the check broken behind for 32-bit hosts.
> > 
> > The check itself should work but it gives a compile warning for me (at
> > least in my small userspace test I did ;) Good catch, thanks.
> 
> To my understanding, the test degraded to value != 0x00010015. That may
> not have the intended effect, no?

I tested this with a small test program in userspace (compiled with
gcc -m32) and the check actually works. But I get a compile warning
because the constant is too large for type long. So I think the check
should work in the 32 bit kernel too.

	Joerg