From: "Michael S. Tsirkin" <mst@redhat.com>
To: mtosatti@redhat.com, kvm@vger.kernel.org, ehabkost@redhat.com
Subject: [PATCH] make-release: make mtime, owner, group consistent
Date: Wed, 2 Jun 2010 18:27:20 +0300 [thread overview]
Message-ID: <20100602152719.GA11840@redhat.com> (raw)
Files from git have modification time set to one
of commit, and owner/group to root.
Making it so for generated files as well makes
it easier to generate an identical tarball from git.
Setting owner/group to root is especially important because
otherwise you must have a user/group with same name
to generate an identical tarball.
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
---
kvm/scripts/make-release | 9 +++++++--
1 files changed, 7 insertions(+), 2 deletions(-)
diff --git a/kvm/scripts/make-release b/kvm/scripts/make-release
index fdc402b..e8051f4 100755
--- a/kvm/scripts/make-release
+++ b/kvm/scripts/make-release
@@ -1,7 +1,7 @@
#!/bin/bash -e
usage() {
- echo "usage: $0 [--upload] [--formal] commit [name] [tarball]"
+ echo "usage: $0 [--upload] [--formal] commit [name] [tarball] [user]"
exit 1
}
@@ -51,17 +51,22 @@ cd "$(dirname "$0")"/../..
mkdir -p "$(dirname "$tarball")"
git archive --prefix="$name/" --format=tar "$commit" > "$tarball"
+mtime=`git show --format=%ct "$commit" --`
+tarargs="--owner=root --group=root --mtime=@$mtime"
+
mkdir -p "$tmpdir"
git cat-file -p "${commit}:roms" | awk ' { print $4, $3 } ' \
> "$tmpdir/EXTERNAL_DEPENDENCIES"
tar -rf "$tarball" --transform "s,^,$name/," -C "$tmpdir" \
+ $tarargs \
"EXTERNAL_DEPENDENCIES"
rm -rf "$tmpdir"
if [[ -n "$formal" ]]; then
mkdir -p "$tmpdir"
echo "$name" > "$tmpdir/KVM_VERSION"
- tar -rf "$tarball" --transform "s,^,$name/," -C "$tmpdir" "KVM_VERSION"
+ tar -rf "$tarball" --transform "s,^,$name/," -C "$tmpdir" "KVM_VERSION" \
+ $tarargs
rm -rf "$tmpdir"
fi
--
1.7.1.12.g42b7f
next reply other threads:[~2010-06-02 15:31 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-02 15:27 Michael S. Tsirkin [this message]
2010-06-04 16:46 ` [PATCH] make-release: make mtime, owner, group consistent Marcelo Tosatti
2010-06-06 16:02 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100602152719.GA11840@redhat.com \
--to=mst@redhat.com \
--cc=ehabkost@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=mtosatti@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).