From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Michael S. Tsirkin" Subject: [PATCH] make-release: make mtime, owner, group consistent Date: Wed, 2 Jun 2010 18:27:20 +0300 Message-ID: <20100602152719.GA11840@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii To: mtosatti@redhat.com, kvm@vger.kernel.org, ehabkost@redhat.com Return-path: Received: from mx1.redhat.com ([209.132.183.28]:65190 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752211Ab0FBPbb (ORCPT ); Wed, 2 Jun 2010 11:31:31 -0400 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o52FVVSZ009007 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Wed, 2 Jun 2010 11:31:31 -0400 Content-Disposition: inline Sender: kvm-owner@vger.kernel.org List-ID: Files from git have modification time set to one of commit, and owner/group to root. Making it so for generated files as well makes it easier to generate an identical tarball from git. Setting owner/group to root is especially important because otherwise you must have a user/group with same name to generate an identical tarball. Signed-off-by: Michael S. Tsirkin --- kvm/scripts/make-release | 9 +++++++-- 1 files changed, 7 insertions(+), 2 deletions(-) diff --git a/kvm/scripts/make-release b/kvm/scripts/make-release index fdc402b..e8051f4 100755 --- a/kvm/scripts/make-release +++ b/kvm/scripts/make-release @@ -1,7 +1,7 @@ #!/bin/bash -e usage() { - echo "usage: $0 [--upload] [--formal] commit [name] [tarball]" + echo "usage: $0 [--upload] [--formal] commit [name] [tarball] [user]" exit 1 } @@ -51,17 +51,22 @@ cd "$(dirname "$0")"/../.. mkdir -p "$(dirname "$tarball")" git archive --prefix="$name/" --format=tar "$commit" > "$tarball" +mtime=`git show --format=%ct "$commit" --` +tarargs="--owner=root --group=root --mtime=@$mtime" + mkdir -p "$tmpdir" git cat-file -p "${commit}:roms" | awk ' { print $4, $3 } ' \ > "$tmpdir/EXTERNAL_DEPENDENCIES" tar -rf "$tarball" --transform "s,^,$name/," -C "$tmpdir" \ + $tarargs \ "EXTERNAL_DEPENDENCIES" rm -rf "$tmpdir" if [[ -n "$formal" ]]; then mkdir -p "$tmpdir" echo "$name" > "$tmpdir/KVM_VERSION" - tar -rf "$tarball" --transform "s,^,$name/," -C "$tmpdir" "KVM_VERSION" + tar -rf "$tarball" --transform "s,^,$name/," -C "$tmpdir" "KVM_VERSION" \ + $tarargs rm -rf "$tmpdir" fi -- 1.7.1.12.g42b7f