From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marcelo Tosatti Subject: Re: [PATCH] msix: fix msix_set/unset_mask_notifier Date: Fri, 4 Jun 2010 13:57:34 -0300 Message-ID: <20100604165734.GB25107@amt.cnet> References: <20100602174934.GA16335@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: kvm@vger.kernel.org, Sridhar Samudrala To: "Michael S. Tsirkin" Return-path: Received: from mx1.redhat.com ([209.132.183.28]:14030 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753282Ab0FDSU3 (ORCPT ); Fri, 4 Jun 2010 14:20:29 -0400 Content-Disposition: inline In-Reply-To: <20100602174934.GA16335@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On Wed, Jun 02, 2010 at 08:49:35PM +0300, Michael S. Tsirkin wrote: > Sridhar Samudrala reported hitting the following assertions > in msix.c when doing a guest reboot or live migration using vhost. > qemu-kvm/hw/msix.c:375: msix_mask_all: Assertion `r >= 0' failed. > qemu-kvm/hw/msix.c:640: msix_unset_mask_notifier: > Assertion `dev->msix_mask_notifier_opaque[vector]' failed. > > The issue is that we didn't clear/set the opaque pointer > when vector is masked. The following patch fixes this. > > Signed-off-by: Sridhar Samudrala > Signed-off-by: Michael S. Tsirkin > --- > > Sridhar, could you test the following please? > > hw/msix.c | 33 ++++++++++++++++----------------- > 1 files changed, 16 insertions(+), 17 deletions(-) Applied, thanks.